Page Index Toggle Pages: 1 [2] 3 
Topic Tools
Very Hot Topic (More than 25 Replies) Main Buttons for YaBB 3 (Read 13,797 times)
Carsten
Ex Member


Re: Main Buttons for YaBB 3
Reply #15 - May 28th, 2009 at 12:46am
Post Tools
cepheid wrote on May 28th, 2009 at 12:38am:
Rather than argue about it here, I'll try to work up a mod to your mod that allows vertical scaling; you can take a look and, if you like it, incorporate it into your mod.If you don't like it, we can toss it.

Yep - that's a plan - check danish time on your world clock - I need my beauty sleep now Smiley
  
Back to top
 
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Main Buttons for YaBB 3
Reply #16 - Jun 15th, 2009 at 10:14pm
Post Tools
Add of Carstens "CSS Buttons 4 YaBB 2.4"-Mod lightly modified to SVN.

Modification:
When saving the style, the 3 MenuX.def files are written new. This way we don't have to call and run the Menu.pl on every call to YaBB. Everything works as at the moment. If you see a problem doing it so Carsten, let me know. The Menu.pl I put into the admin-dir since it is not used in sources and renamed it to Menudef.pl

All ...Buttons/English/ files I didn't remove jet from SVN - for comparison purpose -, must be done later.

What I noticed is,
- that many images are different from the images we have in the Buttons. I think this should be fixed.
- some images have much space until the text others are going over it. We must find a way to have always the same space between the right end of the image and the first character of the text. I suspect this is a matter of image width. They must all have the same and all images must be aligned right.



I found a little bug in your code:
Code
Select All
	else {
		$button_imgurl = qq~$forumstylesurl/$usestyle~;
		if(!-e ("$forumstylesurl/$usestyle/$button_icon.$imgext")) {
			$button_imgurl = qq~$forumstylesurl/default~;
		}
	} 


Must be $forumstylesdir Wink
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Main Buttons for YaBB 3
Reply #17 - Jun 20th, 2009 at 6:27pm
Post Tools
@ Carsten
Can we do something so that the space between the right side of the image has always the same space to the text? At the moment it depends on the width of the image.
« Last Edit: Jun 20th, 2009 at 6:27pm by deti »  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Main Buttons for YaBB 3
Reply #18 - Jun 20th, 2009 at 6:50pm
Post Tools
You might also consider trimming extraneous attributes from the img tags, e.g. there's no need for a TITLE attribute on some of them.  I know the ALT attribute must be there for strict XHTML compliance, so that can be left in, assuming YaBB actually is strict XHTML-compliant... but to reduce code size, I do recommend trimming out anything that isn't strictly necessary.

Also, you might consider making the old buttons available as an option, because on some browsers, rendering a few cached images is faster than rendering a whole LOT of spans... the new buttons are much better in terms of localization, customization, and accessibilty, but that does come at the price of a lot of increased HTML (and hence required processing by the client).

It's probably not a big issue, but it's a thought...
« Last Edit: Jun 20th, 2009 at 6:53pm by cepheid »  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Main Buttons for YaBB 3
Reply #19 - Jun 20th, 2009 at 10:30pm
Post Tools
deti wrote on Jun 20th, 2009 at 6:27pm:
Can we do something so that the space between the right side of the image has always the same space to the text? At the moment it depends on the width of the image.

New Icons will fix it. Comming soon. Smiley
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
OH Eng
Past Team Members
Documentation Team
Offline



Posts: 4,026
Location: Pensacola, Florida USA
Re: Main Buttons for YaBB 3
Reply #20 - Jun 20th, 2009 at 10:55pm
Post Tools
@JetLi - This would be a good opportunity to make all the backgrounds true transparent and not dependent on different palette color transparencies.

markasread.gif - trans. background is blue
new_thread.gif - trans. background is red
poll_create.gif - trans. background is white
etc.

« Last Edit: Jun 20th, 2009 at 10:56pm by OH Eng »  

 
Back to top
 
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Main Buttons for YaBB 3
Reply #21 - Jun 20th, 2009 at 11:12pm
Post Tools
OH Eng wrote on Jun 20th, 2009 at 10:55pm:
This would be a good opportunity to make all the backgrounds true transparent and not dependent on different palette color transparencies.

I know that, already done. Grin
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Derek
Ex Member


Re: Main Buttons for YaBB 3
Reply #22 - Jun 21st, 2009 at 1:02am
Post Tools
OH Eng wrote on May 27th, 2009 at 9:11pm:
A good example of this application might be driven's "skull" template, where it might be cool to add a small skull to each button.


Or mini camp ovens.  Grin Grin Grin Grin
  
Back to top
 
IP Logged
 
OH Eng
Past Team Members
Documentation Team
Offline



Posts: 4,026
Location: Pensacola, Florida USA
Re: Main Buttons for YaBB 3
Reply #23 - Jun 22nd, 2009 at 2:22pm
Post Tools
deti wrote on Jun 20th, 2009 at 6:27pm:
Can we do something so that the space between the right side of the image has always the same space to the text? At the moment it depends on the width of the image.


Yes.  You have to make all the icon images the same physical size... meaning not counting any transparency on either side of the image.  Unless the actual part you see is the same size, the spacing will always be different because they line up at the end of the left_button.png, the same point the css spacing (to text) lines up at.

If you have two images, each 14px wide, one of them the visible part is 14px, the other is 12px with 1px transparent on each side of it.  Set spacing to text at 20px, you will get this:

1.
-----14px image-------|-----6px space----|Text
2.
--1px transp--|---12px visible image---|--1px transp--|----6px space---|Text

The 1px transparency on the image right side will appear to "add" to the 6px of space, making it look like 7px.

So all the visible parts of the icons have to be the same size to make them appear spaced equally.
  

 
Back to top
 
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Main Buttons for YaBB 3
Reply #24 - Jun 22nd, 2009 at 5:55pm
Post Tools
Thanks OH Eng. I think JetLi is already working since the weekend on rebuilding ALL Button images and setting them and the old images all to the same size.
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
Unilat
Development Team
Theme Team
****
Offline



Posts: 1,047
Location: Columbus Ohio, USA
Re: Main Buttons for YaBB 3
Reply #25 - Jun 22nd, 2009 at 6:15pm
Post Tools
Icons not being the same size was an issue with my Thread Tools and Post Tools if you remember. Which I suggest also adding to Y3 as it clears up the clutter incredibly well.
  
Back to top
 
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Main Buttons for YaBB 3
Reply #26 - Jun 22nd, 2009 at 6:33pm
Post Tools
@ Unilat
We are on a good way then! Smiley
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
Unilat
Development Team
Theme Team
****
Offline



Posts: 1,047
Location: Columbus Ohio, USA
Re: Main Buttons for YaBB 3
Reply #27 - Jun 22nd, 2009 at 7:13pm
Post Tools
Did I ever give you the code for those? I know you had asked. My site went down some time ago and has not been up since so I don't have access to them until my server guy gets a hold of me.
  
Back to top
 
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Main Buttons for YaBB 3
Reply #28 - Jun 22nd, 2009 at 7:25pm
Post Tools
Well, a bit off topic here, but what I still have from you is
a Display.template with your version of a thread-page with the message in one line and the profile,... above or below it (I don't remember) and
the AjaxDelete to delete posts with Ajax with the only fault that the colors of the background isn't changed and
the SubBoards code.
« Last Edit: Jun 22nd, 2009 at 7:26pm by deti »  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
Unilat
Development Team
Theme Team
****
Offline



Posts: 1,047
Location: Columbus Ohio, USA
Re: Main Buttons for YaBB 3
Reply #29 - Jun 22nd, 2009 at 7:46pm
Post Tools
Ahh yes. Ok, well if I get access to thread tools and post tools again I'll send you the code. The profile stuff above the post is a very nice new layout that should replace the current one completely in my opinion  Wink Now back on topic.
  
Back to top
 
IP Logged
 
Page Index Toggle Pages: 1 [2] 3 
Topic Tools
 
  « Board Index ‹ Board  ^Top