Page Index Toggle Pages: 1 [2] 3 4 5
Topic Tools
Very Hot Topic (More than 25 Replies) Profile IM protocol names repeated, diff. icons (Read 18,785 times)
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #15 - Jun 12th, 2009 at 7:50am
Post Tools
Status indicators added/modified to see "Online/Offline" in SVN.
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #16 - Jun 12th, 2009 at 8:12am
Post Tools
Awesome deti. Smiley  But, do these new status icons replace the protocol icons?  It looked that way when I browsed the source code.  Or is it how I described earlier, with the onlinestatus to the right of the screenname, which is to the right of the static protocol icon?  Based on the SVN diff, it looks like the former, but I figured I'd ask.
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #17 - Jun 12th, 2009 at 4:23pm
Post Tools
« Last Edit: Jun 12th, 2009 at 10:02pm by Jet Li »  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #18 - Jun 12th, 2009 at 9:37pm
Post Tools
@ deti

OK, so it is like I thought.  I think it would be better to do it the way I suggested previously, namely:
<static icon> <screenname> [onlinestatus] .. that way it looks cleaner, and it also sets us up to implement the other user feature (allowing the onlinestatus to be optional) if so desired.

I'll poke around at the code this weekend and submit a patch.  (I'll have to attach the patch here because I don't have access to the SVN repo.)
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #19 - Jun 13th, 2009 at 6:19am
Post Tools
cepheid wrote on Jun 12th, 2009 at 9:37pm:
I'll poke around at the code this weekend and submit a patch.  (I'll have to attach the patch here because I don't have access to the SVN repo.)

No problem. Just insert in between the code-tags Wink
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #20 - Jun 13th, 2009 at 6:32am
Post Tools
deti, it's usually easier for me to just attach a diff file - is that OK?
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #21 - Jun 13th, 2009 at 7:26am
Post Tools
Yes.
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #22 - Jun 13th, 2009 at 10:53pm
Post Tools
deti, I have the patch available.  It's a standard diff file so you can apply it using "patch -p0 < patchfile" ...

However, I can't seem to attach it here - I guess attachments aren't enabled on this board.  Should I send it via PM, or what?

1) I reordered things so they are as I suggested previously: <staticicon> <screenname> [onlinestatus]
(onlinestatus is only available for AIM, YIM, ICQ, and Skype ... we can add MSN later if we use an external website like IMwrapper.com)

2) If we implement the user preference to disable showing online status, the online status icons can be easily wrapped with an "if" statement.

3) I changed the status icons to ones I like better and which do not conflict with the static protocol icons.

4) The AIM status icons were changed to be local images rather than from an external website, because that way if the external website is unavailable (which happened last night), the images still are.  I will include the images with the patchfile, for inclusion in the template $imagesdir.
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #23 - Jun 14th, 2009 at 6:40am
Post Tools
Can you provide a download link and include all files in a zip?
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #24 - Jun 14th, 2009 at 6:57am
Post Tools
Sure thing.

http://dev.3phase.com/yabb/profile_patch.zip

Contains three files: the .patch, and the 2 AIM status icon images.  (The status icon images should go into yabbfiles/Templates/Forum/default)

If you need more, let me know.
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #25 - Jun 14th, 2009 at 11:51pm
Post Tools
Thank you!

Added to SVN.
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #26 - Jun 15th, 2009 at 12:06am
Post Tools
deti, I don't think the aim_online.gif and aim_offline.gif need to be in the yabb21 template directory... none of the other static icon files are there, and YaBB defaults to looking in the default directory when it can't find them in the regular dir, right?  So only images which are different between the two forums should be there, and it should be safe to remove the aim_*.gif files from the yabb21 dir, I think...
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #27 - Jun 15th, 2009 at 12:13am
Post Tools
cepheid wrote on Jun 15th, 2009 at 12:06am:
... and YaBB defaults to looking in the default directory when it can't find them in the regular dir, right?

No.
$imagesdir is always the chosen template dir. In cases you don't expect users using an individual template image you must use $defaultimagesdir.
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #28 - Jun 15th, 2009 at 12:25am
Post Tools
deti wrote on Jun 15th, 2009 at 12:13am:
In cases you don't expect users using an individual template image you must use $defaultimagesdir.

Ohhhh.  In that case, I should submit another patch, because all of the static icons should be called from $defaultimagesdir - they are not present in the yabb21 template.  Look for that patch later tonight, unless you get around to doing it first.
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #29 - Jun 15th, 2009 at 12:33am
Post Tools
Hmmmm, wait a minute. I'm a bit confused because the images are displayed in yabb21 template mode, but they are not in that folder... Shocked
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: 1 [2] 3 4 5
Topic Tools
 
  « Board Index ‹ Board  ^Top