Page Index Toggle Pages: 1 [2] 3 4 5
Topic Tools
Very Hot Topic (More than 25 Replies) Profile IM protocol names repeated, diff. icons (Read 18,444 times)
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Profile IM protocol names repeated, diff. icons
Reply #54 - Jun 20th, 2009 at 11:10am
Post Tools
cepheid wrote on Jun 20th, 2009 at 11:04am:
but I don't know about the Icon+Text mode in threadview - it looks like it SHOULD work fine there.

Which Template do you use? Then I can change it for your using Template with Icon + Text mode. For each Templates I can choose for Button only, Icon + Text or Text only.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #53 - Jun 20th, 2009 at 11:04am
Post Tools
Jet Li wrote on Jun 20th, 2009 at 10:57am:
No need Boardmod if are mod already included in SVN.

Oh yeah...... I forgot that Carsten's mod was included.  D'oh!!

Jet Li wrote on Jun 20th, 2009 at 10:57am:
not yet

OK, I'll see if I can do it first.  I figured out why it's not working for Carsten's mod and will post an updated regex shortly, but I don't know about the Icon+Text mode in threadview - it looks like it SHOULD work fine there.
  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Profile IM protocol names repeated, diff. icons
Reply #52 - Jun 20th, 2009 at 10:57am
Post Tools
cepheid wrote on Jun 20th, 2009 at 10:37am:
Also, I can't easily use BoardMod because I use Linux on a server without X11, so BoardMod won't work.(I've never had good luck with the Linux version of BoardMod anyway, actually.)

No need Boardmod if are mod already included in SVN. Tongue

cepheid wrote on Jun 20th, 2009 at 10:37am:
Have you made the modifications I recommended above?That way, I can see what the problem is.

not yet. I let do it for deti, I am busy with other things on YaBB_DB.
« Last Edit: Jun 20th, 2009 at 10:59am by Jet Li »  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #51 - Jun 20th, 2009 at 10:37am
Post Tools
Jet Li wrote on Jun 20th, 2009 at 10:26am:
Why not install yourself a YaBB_DB from SVN too?

I will soon, but if deti is seeing a particular problem then it would be good to see an example.  Also, I can't easily use BoardMod because I use Linux on a server without X11, so BoardMod won't work.  (I've never had good luck with the Linux version of BoardMod anyway, actually.)

Jet Li wrote on Jun 20th, 2009 at 10:26am:
my Forum YaBB_DB is already with Carstens Mod.

Have you made the modifications I recommended above?  That way, I can see what the problem is.
  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Profile IM protocol names repeated, diff. icons
Reply #50 - Jun 20th, 2009 at 10:26am
Post Tools
cepheid wrote on Jun 20th, 2009 at 1:50am:
Do you have a forum up with Carsten's mod

my Forum YaBB_DB is already with Carstens Mod.

cepheid wrote on Jun 20th, 2009 at 1:50am:
Can you show me an example, please?I need to see both the HTML and how it renders.

Why not install yourself a YaBB_DB from SVN too? Wink Its more easier.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #49 - Jun 20th, 2009 at 1:50am
Post Tools
LoneWebSurfer wrote on Jun 19th, 2009 at 9:35pm:
just for the sake of variety here is 2 more for aim using the other yim style

Hah. Smiley  But, why should AIM have a style like YIM, and not like ICQ?  I don't think there's a need to pick any particular style.  They can all be different as long as they're "similar," and I think they are all similar enough... I don't actually like the gray background for YIM or AIM, anyway.

deti wrote on Jun 20th, 2009 at 1:22am:
Did you test your code before posting here? I mean, not only if it works, but if it works if you use image URLs without image in that folder?

It did work but I made a transcription mistake when I copied it into the patch.  Sorry.

deti wrote on Jun 20th, 2009 at 1:22am:
The RegExpr didn't match with the new button style from Carstens mod.

No?  I'm not sure why not.  Do you have a forum up with Carsten's mod and my regex, so I can see what the problem is?

deti wrote on Jun 20th, 2009 at 1:22am:
Searching for -e "$imagesdir/$_[0]" will never be true, because it's an URL. This error I brought in before and you overtook it

Ah-ha, so it's YOUR fault! Smiley  Well, yeah, so I guess you have to use the $forumstyledir/$useimages/$_[0] ... but only in the file check.  In the output it should still be $imagesdir or $defaultimagesdir.

deti wrote on Jun 20th, 2009 at 1:22am:
Still not working right: yabb21 template + Icon & Text style for icq, yim, etc. icons in the Threadview.

What's not working right - the regexp, or the ImgLoc function?  Can you show me an example, please?  I need to see both the HTML and how it renders.
« Last Edit: Jun 20th, 2009 at 1:51am by cepheid »  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #48 - Jun 20th, 2009 at 1:22am
Post Tools
Updated SVN.

@ cepheid
Did you test your code before posting here? I mean, not only if it works, but if it works if you use image URLs without image in that folder? Like yabb21 template? I guess not. I had to fix your code and it took time to find the error  Angry Wink

The RegExpr didn't match with the new button style from Carstens mod.
Searching for -e "$imagesdir/$_[0]" will never be true, because it's an URL. This error I brought in before and you overtook it Cheesy Grin

Still not working right: yabb21 template + Icon & Text style for icq, yim, etc. icons in the Threadview.
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #47 - Jun 19th, 2009 at 9:57pm
Post Tools
LoneWebSurfer wrote on Jun 19th, 2009 at 9:35pm:
it has my vote

Then I think we're all in agreement. Smiley  deti, please let me know when those changes are live... I'd make them myself, but it's hard without access to SVN. Wink
  
Back to top
WWW  
IP Logged
 
LoneWebSurfer
Past Team Members
Offline



Posts: 1,279
Re: Profile IM protocol names repeated, diff. icons
Reply #46 - Jun 19th, 2009 at 9:35pm
Post Tools
cepheid wrote on Jun 19th, 2009 at 9:09pm:
also look like the ICQ status icons.

I don't have icq.. but that is what i was thinking when i made it match the yim... would be nice if all status images were as consistent as possible,  on that note.. the other yim image does look much better! it has my vote

Edited:
just for the sake of variety here is 2 more for aim using the other yim style Wink

« Last Edit: Jun 19th, 2009 at 10:07pm by LoneWebSurfer »  

Closed all my sites due to lack of Internet access
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #45 - Jun 19th, 2009 at 9:09pm
Post Tools
LoneWebSurfer wrote on Jun 19th, 2009 at 8:52pm:
I think it looks nicer

Well, the nice part of having the AIM images locally is that one can use anything.  I actually do prefer the ones that I included in the .zip file, though.  I picked those specifically because they are minimal and also look like the ICQ status icons.  Also, I think there's no need to repeat the protocol icon, because it's already there before the screenname.  IMHO the status indicators should be as simple as possible.

I don't really like the current Yahoo ones, and I think they should be changed to a different one, too.

@ deti, in the Yahoo section, can you please change the img link from from "&m=g&t=2&l=us" to "&m=g&t=1&l=us" ?  That uses a smaller, less intrusive indicator.

Thanks. Smiley
  
Back to top
WWW  
IP Logged
 
LoneWebSurfer
Past Team Members
Offline



Posts: 1,279
Re: Profile IM protocol names repeated, diff. icons
Reply #44 - Jun 19th, 2009 at 8:52pm
Post Tools
works for me on 2.1 template while images are in default image directory Smiley
I redid the aim_online/offline image to look more like the yim.. I think it looks nicer .. I included them here should you wish to use them.


  

Closed all my sites due to lack of Internet access
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #43 - Jun 19th, 2009 at 8:34pm
Post Tools
deti wrote on Jun 19th, 2009 at 11:58am:
Thanks for your patches. I will test them tonight.

I presume you're using the latest ones that I mentioned above, right?  Plus the new ImgLoc code from before.  I do think those are the best way to go.  Let me know how it goes...
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #42 - Jun 19th, 2009 at 11:58am
Post Tools
@ cepheid
Thanks for your patches. I will test them tonight.
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #41 - Jun 18th, 2009 at 10:35pm
Post Tools
deti, I found a bug in the profile patch... in loading the AOL status image, I forgot to add the username to the URL.  I also omitted a $ from the URL.  D'oh!!

Edited:
Also, after thinking long and hard about this, I think the best solution is actually to enforce the AIM status icons to be only in $defaultimagesdir, and to not make them template-able.  The reason I say this is that the other status indicators (from ICQ, Skype, and Yahoo) are all served from external websites, and their style is hardcoded into Profile.pl ... there is no user preference to change the style, which means that it will show up just the same on every template.

Until/unless we implement a means for the other status indicators to be changeable by template, I think the AIM indicator should also be hardcoded.  This would not only be more consistent, it would keep the regex slimmer and faster, and would get rid of any question about where the images need to go.

Once we implement template-able styles for the Yahoo, ICQ, and Skype indicators, then the AIM indicator should be template-able, as well.


To that end, please make the following changes:
1) Please use the regexp as given in reply #35, i.e.
Code
Select All
      if ($imagesdir ne $defaultimagesdir) {
            $output =~ s~(src|value)\s*=\s*("|')$imagesdir/([^'"]+)\2~ "$1=$2" . &ImgLoc($3) . $2 ~eisg;
      } 



2) To fix the status indicator (both the bug and the directory issue), in Profile.pl, find:
Code
Select All
<a href="aim:goim?screenname=${$uid.$user}{'aim'}&amp;me
ssage=Hi,+are+you+there?"><img src="$imagesdir/aim.gif" alt="${$uid.$user}{'aim'
}" border="0" style="vertical-align: middle;" /> $aim_user <img src="http://big.
oscar.aol.com/?on_url=$imagesdir/aim_online.gif&amp;off_url=imagesdir/aim_offlin
e.gif" alt="${$uid.$user}{'aim'}" border="0" style="vertical-align: middle;" /><
/a> 



and replace with:
Code
Select All
<a href="aim:goim?screenname=${$uid.$user}{'aim'}&amp;me
ssage=Hi,+are+you+there?"><img src="$imagesdir/aim.gif" alt="${$uid.$user}{'aim'
}" border="0" style="vertical-align: middle;" /> $aim_user <img src="http://big.
oscar.aol.com/${$uid.$user}{'aim'}?on_url=$defaultimagesdir/aim_online.gif&amp;off_url=$defaultimagesdir/aim_offlin
e.gif" alt="${$uid.$user}{'aim'}" border="0" style="vertical-align: middle;" /><
/a> 

« Last Edit: Jun 19th, 2009 at 2:31am by cepheid »  
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #40 - Jun 18th, 2009 at 10:28pm
Post Tools
LoneWebSurfer wrote on Jun 18th, 2009 at 8:58pm:
2.1 template the aim online/offline image shows.. but only if it is in the 2.1 image directory..( said that as im not sure if this was the desired result.)

No, that was not the desired result.  If you put the code back to how it was before my changes, do the online/offline images show up even if they're not in the 2.1 image directory?

Edited:
Ah, I know why this is happening.  It's because the regexp isn't picking up the image URL, since it's buried within the AIM URL.  darn.  It's really not worth putting it into the regex because that specific URL format appears in exactly one place - the Profile page - and there's no need to slow the regex down with additional checks when we know it will appear only once.  Unless, of course, someone puts it in their signature or something.  darn!  But.....


OK, to cover this issue, if we don't want to add the aim_online and aim_offline images to each template directory, then the regexp can be modified as such:
Code
Select All
      if ($imagesdir ne $defaultimagesdir) {
            $output =~ s~(src|value|_url)\s*=\s*(['"]?)$imagesdir/([^'"&\s]+)\2~ "$1=$2" . &ImgLoc($3) . $2 ~eisg;
      } 


This modifies the regex by looking for an _url prefix in addition to src or value, it makes the quotation marks optional, and it disallows ampersands or whitespace in the image name (which should be fine, since technically neither of those are legal filename character within URLs anyway, and should always be url-encoded).

If we would rather keep the regexp "slimmer" as per the previous example, then I recommend putting the aim_*line.gif images into each template directory.  If we are OK using the slightly slower regexp above (it is still much faster than the 4 regexps used previously!), then we can omit the .gifs from the individual templates (unless someone wants to use different files in that template, of course).

Edited:
But, I don't think this is what we should do.  See below.
« Last Edit: Jun 19th, 2009 at 2:28am by cepheid »  
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: 1 [2] 3 4 5
Topic Tools
 
  « Board Index ‹ Board  ^Top