Page Index Toggle Pages: 1 2 3 [4] 5 
Topic Tools
Very Hot Topic (More than 25 Replies) Profile IM protocol names repeated, diff. icons (Read 18,777 times)
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #45 - Jun 19th, 2009 at 9:09pm
Post Tools
LoneWebSurfer wrote on Jun 19th, 2009 at 8:52pm:
I think it looks nicer

Well, the nice part of having the AIM images locally is that one can use anything.  I actually do prefer the ones that I included in the .zip file, though.  I picked those specifically because they are minimal and also look like the ICQ status icons.  Also, I think there's no need to repeat the protocol icon, because it's already there before the screenname.  IMHO the status indicators should be as simple as possible.

I don't really like the current Yahoo ones, and I think they should be changed to a different one, too.

@ deti, in the Yahoo section, can you please change the img link from from "&m=g&t=2&l=us" to "&m=g&t=1&l=us" ?  That uses a smaller, less intrusive indicator.

Thanks. Smiley
  
Back to top
WWW  
IP Logged
 
LoneWebSurfer
Past Team Members
Offline



Posts: 1,279
Re: Profile IM protocol names repeated, diff. icons
Reply #46 - Jun 19th, 2009 at 9:35pm
Post Tools
cepheid wrote on Jun 19th, 2009 at 9:09pm:
also look like the ICQ status icons.

I don't have icq.. but that is what i was thinking when i made it match the yim... would be nice if all status images were as consistent as possible,  on that note.. the other yim image does look much better! it has my vote

Edited:
just for the sake of variety here is 2 more for aim using the other yim style Wink

« Last Edit: Jun 19th, 2009 at 10:07pm by LoneWebSurfer »  

Closed all my sites due to lack of Internet access
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #47 - Jun 19th, 2009 at 9:57pm
Post Tools
LoneWebSurfer wrote on Jun 19th, 2009 at 9:35pm:
it has my vote

Then I think we're all in agreement. Smiley  deti, please let me know when those changes are live... I'd make them myself, but it's hard without access to SVN. Wink
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #48 - Jun 20th, 2009 at 1:22am
Post Tools
Updated SVN.

@ cepheid
Did you test your code before posting here? I mean, not only if it works, but if it works if you use image URLs without image in that folder? Like yabb21 template? I guess not. I had to fix your code and it took time to find the error  Angry Wink

The RegExpr didn't match with the new button style from Carstens mod.
Searching for -e "$imagesdir/$_[0]" will never be true, because it's an URL. This error I brought in before and you overtook it Cheesy Grin

Still not working right: yabb21 template + Icon & Text style for icq, yim, etc. icons in the Threadview.
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #49 - Jun 20th, 2009 at 1:50am
Post Tools
LoneWebSurfer wrote on Jun 19th, 2009 at 9:35pm:
just for the sake of variety here is 2 more for aim using the other yim style

Hah. Smiley  But, why should AIM have a style like YIM, and not like ICQ?  I don't think there's a need to pick any particular style.  They can all be different as long as they're "similar," and I think they are all similar enough... I don't actually like the gray background for YIM or AIM, anyway.

deti wrote on Jun 20th, 2009 at 1:22am:
Did you test your code before posting here? I mean, not only if it works, but if it works if you use image URLs without image in that folder?

It did work but I made a transcription mistake when I copied it into the patch.  Sorry.

deti wrote on Jun 20th, 2009 at 1:22am:
The RegExpr didn't match with the new button style from Carstens mod.

No?  I'm not sure why not.  Do you have a forum up with Carsten's mod and my regex, so I can see what the problem is?

deti wrote on Jun 20th, 2009 at 1:22am:
Searching for -e "$imagesdir/$_[0]" will never be true, because it's an URL. This error I brought in before and you overtook it

Ah-ha, so it's YOUR fault! Smiley  Well, yeah, so I guess you have to use the $forumstyledir/$useimages/$_[0] ... but only in the file check.  In the output it should still be $imagesdir or $defaultimagesdir.

deti wrote on Jun 20th, 2009 at 1:22am:
Still not working right: yabb21 template + Icon & Text style for icq, yim, etc. icons in the Threadview.

What's not working right - the regexp, or the ImgLoc function?  Can you show me an example, please?  I need to see both the HTML and how it renders.
« Last Edit: Jun 20th, 2009 at 1:51am by cepheid »  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Profile IM protocol names repeated, diff. icons
Reply #50 - Jun 20th, 2009 at 10:26am
Post Tools
cepheid wrote on Jun 20th, 2009 at 1:50am:
Do you have a forum up with Carsten's mod

my Forum YaBB_DB is already with Carstens Mod.

cepheid wrote on Jun 20th, 2009 at 1:50am:
Can you show me an example, please?I need to see both the HTML and how it renders.

Why not install yourself a YaBB_DB from SVN too? Wink Its more easier.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #51 - Jun 20th, 2009 at 10:37am
Post Tools
Jet Li wrote on Jun 20th, 2009 at 10:26am:
Why not install yourself a YaBB_DB from SVN too?

I will soon, but if deti is seeing a particular problem then it would be good to see an example.  Also, I can't easily use BoardMod because I use Linux on a server without X11, so BoardMod won't work.  (I've never had good luck with the Linux version of BoardMod anyway, actually.)

Jet Li wrote on Jun 20th, 2009 at 10:26am:
my Forum YaBB_DB is already with Carstens Mod.

Have you made the modifications I recommended above?  That way, I can see what the problem is.
  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Profile IM protocol names repeated, diff. icons
Reply #52 - Jun 20th, 2009 at 10:57am
Post Tools
cepheid wrote on Jun 20th, 2009 at 10:37am:
Also, I can't easily use BoardMod because I use Linux on a server without X11, so BoardMod won't work.(I've never had good luck with the Linux version of BoardMod anyway, actually.)

No need Boardmod if are mod already included in SVN. Tongue

cepheid wrote on Jun 20th, 2009 at 10:37am:
Have you made the modifications I recommended above?That way, I can see what the problem is.

not yet. I let do it for deti, I am busy with other things on YaBB_DB.
« Last Edit: Jun 20th, 2009 at 10:59am by Jet Li »  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #53 - Jun 20th, 2009 at 11:04am
Post Tools
Jet Li wrote on Jun 20th, 2009 at 10:57am:
No need Boardmod if are mod already included in SVN.

Oh yeah...... I forgot that Carsten's mod was included.  D'oh!!

Jet Li wrote on Jun 20th, 2009 at 10:57am:
not yet

OK, I'll see if I can do it first.  I figured out why it's not working for Carsten's mod and will post an updated regex shortly, but I don't know about the Icon+Text mode in threadview - it looks like it SHOULD work fine there.
  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Profile IM protocol names repeated, diff. icons
Reply #54 - Jun 20th, 2009 at 11:10am
Post Tools
cepheid wrote on Jun 20th, 2009 at 11:04am:
but I don't know about the Icon+Text mode in threadview - it looks like it SHOULD work fine there.

Which Template do you use? Then I can change it for your using Template with Icon + Text mode. For each Templates I can choose for Button only, Icon + Text or Text only.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #55 - Jun 20th, 2009 at 11:23am
Post Tools
Jet Li wrote on Jun 20th, 2009 at 11:10am:
Which Template do you use? Then I can change it for your using Template with Icon + Text mode. For each Templates I can choose for Button only, Icon + Text or Text only.

On your forum I just use the default atisilver, but I tested Icon+Text on my own stock v2.4 forum with the yabb21 template.  Looking at how it's constructed, the regex should work just fine.  The ONLY problem that might occur is with the JS calls to Spaminator because those use escaped double-quotes instead of using single-quotes... but the previous regex couldn't handle those either, which is why email.gif had to be included in every non-default template.  I can either rewrite my regex to handle that, or we can rewrite the calls to Spaminator to use single quotes (which is the preferred solution).

Looking at the Icon+Text links for the YIM, ICQ, etc. though, everything SHOULD work fine with the regex I gave before.  I'll have to test this locally.
  
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #56 - Jun 20th, 2009 at 1:42pm
Post Tools
@ Jet Li, I see that you've changed it to Icon+Text... and I can't see any problem with the YIM/ICQ/etc. icons as deti mentioned.  I do see the problem with Carsten's buttons, that is easy to fix.

Edited:
Oh, it looks like all of your IM icons are in the atisilver template, I guess because it's the default template.  Do you have a different template that you can make Icon+Text, so I can see if that has a problem?


Edited:
OK, I tried all of your other templates, and it looks like the regexp is working just fine there.  So, I'm STILL not sure what problem deti was talking about...


@ deti, what did you mean by a problem with the IM icons in threadview?

Also, it looks like we need a bit of code cleanup (for consistency) for the IM icons in threadview... they should have a link even if there's an onclick setting, so that people without JS can still use it.  I'll work on that later.
« Last Edit: Jun 20th, 2009 at 1:46pm by cepheid »  
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #57 - Jun 20th, 2009 at 4:00pm
Post Tools
cepheid wrote on Jun 20th, 2009 at 11:04am:
I figured out why it's not working for Carsten's mod and will post an updated regex shortly

OK, here it is.  This now SHOULD work for all images, whether loaded via HTML, JS, or CSS.  I haven't yet built an SVN forum on which to test it, but my manual tests all came out fine.

So, use the following regex:
Code
Select All
      if ($imagesdir ne $defaultimagesdir) {
            $output =~ s~((src=|value=)|url\()(['"]?)$imagesdir/([^'" >;]+)\3((?(2)[ >;]|\)))~ "$1$3" . &ImgLoc($4) . $3 . $5 ~ eisg;
      } 



Also, I would recommend using the aim_online.gif and aim_offline.gif that I included in my .zip file, rather than the ones that LoneWebSurfer made... I appreciate his effort but I like the other ones better!  They are consistent with the ICQ images, as well.

deti, I'm still unsure about what error you meant regarding the IM icons in threadview, because on Jet Li's forum, I don't see any error.

Y'know, instead of posting all the code here, maybe I should just have access to the SVN repo... Wink
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #58 - Jun 20th, 2009 at 4:11pm
Post Tools
Thanks for the code but I had allready fixed it by myself, see my last post. Wink
That is probably the reason why you didn't see it ony your actual SVN forum Smiley

cepheid wrote on Jun 20th, 2009 at 4:00pm:
Also, I would recommend using the aim_online.gif and aim_offline.gif that I included in my .zip file, rather than the ones that LoneWebSurfer made... I appreciate his effort but I like the other ones better!  They are consistent with the ICQ images, as well.

I'll change it back soon.

cepheid wrote on Jun 20th, 2009 at 4:00pm:
deti, I'm still unsure about what error you meant regarding the IM icons in threadview, because on Jet Li's forum, I don't see any error.

--URL removed to avoid bots getting there--
But I think we should add this icons into the Menu.def too instead of using an idividual code for them, just because one of them changes by onlinestatus.
« Last Edit: Jun 20th, 2009 at 5:15pm by deti »  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #59 - Jun 20th, 2009 at 4:29pm
Post Tools
deti wrote on Jun 20th, 2009 at 4:11pm:
Thanks for the code but I had allready fixed it by myself, see my last post.

I know, but your fix (in Subs.pl version 65) actually isn't compatible with Carsten's mod, either, and has a couple of other important omissions.  The biggest issue is that your regex requires quotes around the URL, but Carsten does not use quotes (which is acceptable by W3C and is actually preferred, because the quotes can cause problems with older browsers).  If you omit the requirement for quotes, you must then make sure to close the parentheses.  Also, while it's not really that important, your regex allows mismatched syntax which isn't valid HTML (so it wouldn't ever appear in YaBB, but might appear in user content and hence should be excluded).

I would recommend using the regex I gave above; it is more complete and, more importantly, is compatible with Carsten's style of not using quotes around the URL.

deti wrote on Jun 20th, 2009 at 4:11pm:
But I think we should add this icons into the Menu.def too instead of using an idividual code for them, just because one of them changes by onlinestatus.

First, that's not Icon+Text view, that's Button view, isn't it?  Icon+Text view tries to load icons, but yours is trying to load buttons.

Also, this has nothing to do with my code, because the buttons are stored in /yabbfiles/Buttons/English, which is not $imagesdir, nor does it differ from one template to another.

It looks like you are missing the /yabbfiles/Buttons/English files that your forum is trying to load, but that's not because of my code...
« Last Edit: Jun 20th, 2009 at 4:39pm by cepheid »  
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: 1 2 3 [4] 5 
Topic Tools
 
  « Board Index ‹ Board  ^Top