Page Index Toggle Pages: [1] 2 3 ... 5
Topic Tools
Very Hot Topic (More than 25 Replies) Profile IM protocol names repeated, diff. icons (Read 18,460 times)
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #69 - Jun 23rd, 2009 at 7:05pm
Post Tools
LoneWebSurfer wrote on Jun 23rd, 2009 at 12:02pm:
Does the wording have to be included?

Yahoo and Skype don't have non-worded indicators.  Personally, I prefer including the words.  Why reduce the info?  Those who don't understand "online/offline" will hopefully understand the colors.
  
Back to top
WWW  
IP Logged
 
LoneWebSurfer
Past Team Members
Offline



Posts: 1,279
Re: Profile IM protocol names repeated, diff. icons
Reply #68 - Jun 23rd, 2009 at 12:02pm
Post Tools
I was guessing as much, with it using the images from other servers. Was hoping tho.
Does the wording have to be included? as you said..green is universal.. I know icq has green indicators.. not sure about yim.
Dont get me wrong.. its not an issue to me, after all English is my only language Grin  I'm just throwing out thoughts and ideas
  

Closed all my sites due to lack of Internet access
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #67 - Jun 22nd, 2009 at 9:07pm
Post Tools
LoneWebSurfer wrote on Jun 22nd, 2009 at 6:21pm:
Just thought of this today..but what about other languages.. a russian or german board should have online in their set language shouldnt it? what can be done (if anything) to address this?

Nothing, unfortunately.  The Skype, YIM, and ICQ images are all loaded from external servers, and I don't believe they support languages.  The AIM icons could be done in another language if they are made part of the template, but since none of the other images are, I don't think that really matters.

As long as the "offline" is Red or Gray and the "online" is Green, I think that's fairly universal, though... and since that's pretty much how it is, I think most people should understand.  Unfortunately, until Skype/ICQ/YIM support other languages in their presence indicators, I don't think we can do anything.
  
Back to top
WWW  
IP Logged
 
LoneWebSurfer
Past Team Members
Offline



Posts: 1,279
Re: Profile IM protocol names repeated, diff. icons
Reply #66 - Jun 22nd, 2009 at 6:21pm
Post Tools
Just thought of this today..but what about other languages.. a russian or german board should have online in their set language shouldnt it? what can be done (if anything) to address this?
  

Closed all my sites due to lack of Internet access
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #65 - Jun 20th, 2009 at 5:46pm
Post Tools
deti wrote on Jun 20th, 2009 at 5:34pm:
Hmmm, are you sure about what you wrote about old browsers? Which ones/how old?

I am quite sure, yes.  But, yes, it's only for OLD browsers (like IE for Mac).  But... if you want to keep your regex, you have to change Carsten's code to use the quotes, otherwise your regex won't work.  I would also recommend changing it so that it properly matches quotes and the closing parenthesis, to ensure proper syntax.

I think my regex is more versatile and safer for future updates (because it properly handles every case, with or without quotes, and ensures proper syntax with matching quotes/parens)... I understand if you want to keep yours, and obviously I'm not yet an official dev... just offering my professional opinion. Smiley

deti wrote on Jun 20th, 2009 at 5:34pm:
Come down everybody. Nobody is offending someone.

Don't worry, I didn't take offense.  I was just explaining. Smiley  I forgot the smiley! Cheesy
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #64 - Jun 20th, 2009 at 5:34pm
Post Tools
cepheid wrote on Jun 20th, 2009 at 4:29pm:
which is acceptable by W3C and is actually preferred, because the quotes can cause problems with older browsers

Hmmm, are you sure about what you wrote about old browsers? Which ones/how old? I would prefer my RegEx and changed already the Menudef.pl to match it, only the Menu[1|2|3].def I actually didn't update because I wanted to wait for eventually adding the Thread-page-yim|icq|...-BUTTONS/ICONS into the .def file.

cepheid wrote on Jun 20th, 2009 at 4:29pm:
First, that's not Icon+Text view, that's Button view, isn't it?

Ups, you are right, I was wrong. With Buttons there is also a problem. But both are not related to this thread here. I will look for a fix and post it on Carstens-Mod thread.

cepheid wrote on Jun 20th, 2009 at 4:29pm:
Also, this has nothing to do with my code, because the buttons are stored in /yabbfiles/Buttons/English, which is not $imagesdir, nor does it differ from one template to another.It looks like you are missing the /yabbfiles/Buttons/English files that your forum is trying to load, but that's not because of my code...

You are right. And if you think I gave you the fault on this, I am sorry. Wasn't my intention. I renamed this folder on my server because it will be removed later. Now I must look for a fix on that.

cepheid wrote on Jun 20th, 2009 at 4:51pm:
I'm just defending myself!

Come down everybody. Nobody is offending someone.
@cepheid: LetLi is sometimes a bit rough but he is a good guy! Sometimes it's a bit hard to express things if English is not your native language.
« Last Edit: Jun 20th, 2009 at 5:36pm by deti »  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #63 - Jun 20th, 2009 at 4:51pm
Post Tools
Jet Li wrote on Jun 20th, 2009 at 4:49pm:
Please wait until the feature is finished!

Hey, I'm not the one who said it was broken... deti complained about it first and said it was a problem with my code.  I'm just defending myself!
  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Profile IM protocol names repeated, diff. icons
Reply #62 - Jun 20th, 2009 at 4:49pm
Post Tools
cepheid wrote on Jun 20th, 2009 at 4:45pm:
Take a look at the link he provided and view the source code.Something's broken there.

No I no take look, because I have same SVN. Please wait until the feature is finished!
« Last Edit: Jun 20th, 2009 at 4:49pm by Jet Li »  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #61 - Jun 20th, 2009 at 4:45pm
Post Tools
Jet Li wrote on Jun 20th, 2009 at 4:42pm:
not missing.

Well, it's missing in the sense that deti's forum is trying to load buttons from that directory, and those files aren't there.  Take a look at the link he provided and view the source code.  Something's broken there.
  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Profile IM protocol names repeated, diff. icons
Reply #60 - Jun 20th, 2009 at 4:42pm
Post Tools
cepheid wrote on Jun 20th, 2009 at 4:29pm:
missing the /yabbfiles/Buttons/English

not missing. Because we have Carstens mod and the buttons no need anymore. Current I convert the icon on Buttons into gif's which looks better than the current gif images.

And you no looking at this topic. Tongue

http://www.yabbforum.com/community/YaBB.pl?num=1243427088/16#16
« Last Edit: Jun 20th, 2009 at 4:43pm by Jet Li »  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #59 - Jun 20th, 2009 at 4:29pm
Post Tools
deti wrote on Jun 20th, 2009 at 4:11pm:
Thanks for the code but I had allready fixed it by myself, see my last post.

I know, but your fix (in Subs.pl version 65) actually isn't compatible with Carsten's mod, either, and has a couple of other important omissions.  The biggest issue is that your regex requires quotes around the URL, but Carsten does not use quotes (which is acceptable by W3C and is actually preferred, because the quotes can cause problems with older browsers).  If you omit the requirement for quotes, you must then make sure to close the parentheses.  Also, while it's not really that important, your regex allows mismatched syntax which isn't valid HTML (so it wouldn't ever appear in YaBB, but might appear in user content and hence should be excluded).

I would recommend using the regex I gave above; it is more complete and, more importantly, is compatible with Carsten's style of not using quotes around the URL.

deti wrote on Jun 20th, 2009 at 4:11pm:
But I think we should add this icons into the Menu.def too instead of using an idividual code for them, just because one of them changes by onlinestatus.

First, that's not Icon+Text view, that's Button view, isn't it?  Icon+Text view tries to load icons, but yours is trying to load buttons.

Also, this has nothing to do with my code, because the buttons are stored in /yabbfiles/Buttons/English, which is not $imagesdir, nor does it differ from one template to another.

It looks like you are missing the /yabbfiles/Buttons/English files that your forum is trying to load, but that's not because of my code...
« Last Edit: Jun 20th, 2009 at 4:39pm by cepheid »  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Profile IM protocol names repeated, diff. icons
Reply #58 - Jun 20th, 2009 at 4:11pm
Post Tools
Thanks for the code but I had allready fixed it by myself, see my last post. Wink
That is probably the reason why you didn't see it ony your actual SVN forum Smiley

cepheid wrote on Jun 20th, 2009 at 4:00pm:
Also, I would recommend using the aim_online.gif and aim_offline.gif that I included in my .zip file, rather than the ones that LoneWebSurfer made... I appreciate his effort but I like the other ones better!  They are consistent with the ICQ images, as well.

I'll change it back soon.

cepheid wrote on Jun 20th, 2009 at 4:00pm:
deti, I'm still unsure about what error you meant regarding the IM icons in threadview, because on Jet Li's forum, I don't see any error.

--URL removed to avoid bots getting there--
But I think we should add this icons into the Menu.def too instead of using an idividual code for them, just because one of them changes by onlinestatus.
« Last Edit: Jun 20th, 2009 at 5:15pm by deti »  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #57 - Jun 20th, 2009 at 4:00pm
Post Tools
cepheid wrote on Jun 20th, 2009 at 11:04am:
I figured out why it's not working for Carsten's mod and will post an updated regex shortly

OK, here it is.  This now SHOULD work for all images, whether loaded via HTML, JS, or CSS.  I haven't yet built an SVN forum on which to test it, but my manual tests all came out fine.

So, use the following regex:
Code
Select All
      if ($imagesdir ne $defaultimagesdir) {
            $output =~ s~((src=|value=)|url\()(['"]?)$imagesdir/([^'" >;]+)\3((?(2)[ >;]|\)))~ "$1$3" . &ImgLoc($4) . $3 . $5 ~ eisg;
      } 



Also, I would recommend using the aim_online.gif and aim_offline.gif that I included in my .zip file, rather than the ones that LoneWebSurfer made... I appreciate his effort but I like the other ones better!  They are consistent with the ICQ images, as well.

deti, I'm still unsure about what error you meant regarding the IM icons in threadview, because on Jet Li's forum, I don't see any error.

Y'know, instead of posting all the code here, maybe I should just have access to the SVN repo... Wink
  
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #56 - Jun 20th, 2009 at 1:42pm
Post Tools
@ Jet Li, I see that you've changed it to Icon+Text... and I can't see any problem with the YIM/ICQ/etc. icons as deti mentioned.  I do see the problem with Carsten's buttons, that is easy to fix.

Edited:
Oh, it looks like all of your IM icons are in the atisilver template, I guess because it's the default template.  Do you have a different template that you can make Icon+Text, so I can see if that has a problem?


Edited:
OK, I tried all of your other templates, and it looks like the regexp is working just fine there.  So, I'm STILL not sure what problem deti was talking about...


@ deti, what did you mean by a problem with the IM icons in threadview?

Also, it looks like we need a bit of code cleanup (for consistency) for the IM icons in threadview... they should have a link even if there's an onclick setting, so that people without JS can still use it.  I'll work on that later.
« Last Edit: Jun 20th, 2009 at 1:46pm by cepheid »  
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Profile IM protocol names repeated, diff. icons
Reply #55 - Jun 20th, 2009 at 11:23am
Post Tools
Jet Li wrote on Jun 20th, 2009 at 11:10am:
Which Template do you use? Then I can change it for your using Template with Icon + Text mode. For each Templates I can choose for Button only, Icon + Text or Text only.

On your forum I just use the default atisilver, but I tested Icon+Text on my own stock v2.4 forum with the yabb21 template.  Looking at how it's constructed, the regex should work just fine.  The ONLY problem that might occur is with the JS calls to Spaminator because those use escaped double-quotes instead of using single-quotes... but the previous regex couldn't handle those either, which is why email.gif had to be included in every non-default template.  I can either rewrite my regex to handle that, or we can rewrite the calls to Spaminator to use single quotes (which is the preferred solution).

Looking at the Icon+Text links for the YIM, ICQ, etc. though, everything SHOULD work fine with the regex I gave before.  I'll have to test this locally.
  
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: [1] 2 3 ... 5
Topic Tools
 
  « Board Index ‹ Board  ^Top