Page Index Toggle Pages: 1
Topic Tools
Normal Topic [SVN] "last post" weirdness on newly set-up forum (Read 3,636 times)
cepheid
Senior Member
****
Offline



Posts: 516
[SVN] "last post" weirdness on newly set-up forum
Jun 24th, 2009 at 11:49pm
Post Tools
I just set up a new forum from the SVN code.  Immediately after I set it up, I noticed some weirdness with the "last post" icon in the board listing.  I went through the entire Admin preferences, setting everything up properly, but this weirdness hasn't gone away.

The problem doesn't appear here, so either this was newly introduced to SVN or it's a bug that has always been there but only for brand new forums... apparently upgraded forums don't have this issue.

In the attached screenshot, you'll see that the first "last post" icon (for General Board) has a border around it.  The HTML code for it is messed up, as can be seen in the Firebug console at the bottom... the IMG code looks like:
Code
Select All
<img 0="" alt=" border=" src="http://dev.3phase.com/yabbfiles/Templates/Forum/default/lastpost.gif"/> 


As is clear, there is an extraneous 0="" in there, and the quotes for the ALT and BORDER attributes aren't closed properly.  The same improper code is used for all of the "last post" icons, although none of the others show the border issue, because of how the browser interprets improper syntax.

I'm not sure where this is happening so I don't know if I can fix it just yet.
« Last Edit: Jun 25th, 2009 at 4:54am by Jet Li »  

yabb_newforum_lastpost_weirdness.png (Attachment deleted)
Back to top
WWW  
IP Logged
 
LoneWebSurfer
Past Team Members
Offline



Posts: 1,279
Re: "last post" weirdness on newly set-up forum
Reply #1 - Jun 25th, 2009 at 12:24am
Post Tools
must have been introduced... as my 2.4 was a new install without this issue..
seems the first part is getting jumbled..
also.. my svn copy downloaded 2 or 3 days ago... does not do it.. shows correctly as below.
Code
Select All
<img src="http://www......../public_html/yabbfiles/Templates/Forum/default/lastpost.gif" alt="Last Post" title="Last Post" border="0" /> 

« Last Edit: Jun 25th, 2009 at 12:31am by LoneWebSurfer »  

Closed all my sites due to lack of Internet access
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: "last post" weirdness on newly set-up forum
Reply #2 - Jun 25th, 2009 at 12:58am
Post Tools
Found the problem.  It's in the Menu*.def files... the 'lastpost' entry in all three files has improper syntax in the ALT attribute.  In fact, there are a few others that have this same problem.

I'll post a patch here shortly.
  
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: "last post" weirdness on newly set-up forum
Reply #3 - Jun 25th, 2009 at 1:19am
Post Tools
Patch ready ... http://dev.3phase.com/yabb/menudef.patch

In looking at those files, I am overcome with how redundant they are.  There really only needs to be a single Menu.def file that builds the proper style as needed.  Carsten attempted this with his mod but his file was too simple, and required all strings to be built from scratch on every call.  However, there is a proper middle-ground, where the menu doesn't have to be built with a procedure each time, yet we can have a single unified file where only a single line needs to be edited, not three.

I'll work on this as I can.
  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: "last post" weirdness on newly set-up forum
Reply #4 - Jun 25th, 2009 at 4:36am
Post Tools
cepheid wrote on Jun 25th, 2009 at 1:19am:
Patch ready

its alrady fixed. Get new files from SVN and save once Style Sheet again. Smiley
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: "last post" weirdness on newly set-up forum
Reply #5 - Jun 25th, 2009 at 4:43am
Post Tools
Jet Li wrote on Jun 25th, 2009 at 4:36am:
Get new files from SVN and save once Style Sheet again.

Jet Li, this was from a forum I set up only a few hours ago, using the very latest SVN.  No changes have been made to SVN since I downloaded and installed the forum.  Looking on SVN, the default Menu*.def files still have this problem.

I should not be required to save the Style Sheet in order to get a working forum - it should work out of the box.  This patch fixes the default Menu*.def files.  It should be applied.
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: [SVN] "last post" weirdness on newly set-up forum
Reply #6 - Jun 26th, 2009 at 6:38pm
Post Tools
New Variables/Menu[1|2|3].def in SVN.
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: 1
Topic Tools
 
  « Board Index ‹ Board  ^Top