YaBB Community and Support Forum
YaBB Home About YaBB Download YaBB YaBB Support Customize Your Forum Development Contribute to the Project
  Welcome, Guest. Please Login or Register


 
Page Index Toggle Pages: 1
Topic Tools
 
[SVN] "last post" weirdness on newly set-up forum (Read 3,387 times)
 Jun 24th, 2009 at 11:49pm
There are no actions to perform.  

cepheid 
Senior Member
****
Offline
Posts: 516


None
[SVN] "last post" weirdness on newly set-up forum
I just set up a new forum from the SVN code.  Immediately after I set it up, I noticed some weirdness with the "last post" icon in the board listing.  I went through the entire Admin preferences, setting everything up properly, but this weirdness hasn't gone away.

The problem doesn't appear here, so either this was newly introduced to SVN or it's a bug that has always been there but only for brand new forums... apparently upgraded forums don't have this issue.

In the attached screenshot, you'll see that the first "last post" icon (for General Board) has a border around it.  The HTML code for it is messed up, as can be seen in the Firebug console at the bottom... the IMG code looks like:
Code Select All
<img 0="" alt=" border=" src="http://dev.3phase.com/yabbfiles/Templates/Forum/default/lastpost.gif"/> 


As is clear, there is an extraneous 0="" in there, and the quotes for the ALT and BORDER attributes aren't closed properly.  The same improper code is used for all of the "last post" icons, although none of the others show the border issue, because of how the browser interprets improper syntax.

I'm not sure where this is happening so I don't know if I can fix it just yet.
« Last Edit: Jun 25th, 2009 at 4:54am by Jet Li »  
yabb_newforum_lastpost_weirdness.png (Attachment deleted)
WWW  
IP Logged  
 Reply #1 - Jun 25th, 2009 at 12:24am
There are no actions to perform.  

LoneWebSurfer 
Past Team Members
Offline
Posts: 1,279


None
Re: "last post" weirdness on newly set-up forum
must have been introduced... as my 2.4 was a new install without this issue..
seems the first part is getting jumbled..
also.. my svn copy downloaded 2 or 3 days ago... does not do it.. shows correctly as below.
Code Select All
<img src="http://www......../public_html/yabbfiles/Templates/Forum/default/lastpost.gif" alt="Last Post" title="Last Post" border="0" /> 

« Last Edit: Jun 25th, 2009 at 12:31am by LoneWebSurfer »  
Closed all my sites due to lack of Internet access
WWW  
IP Logged  
 Reply #2 - Jun 25th, 2009 at 12:58am
There are no actions to perform.  

cepheid 
Senior Member
****
Offline
Posts: 516


None
Re: "last post" weirdness on newly set-up forum
Found the problem.  It's in the Menu*.def files... the 'lastpost' entry in all three files has improper syntax in the ALT attribute.  In fact, there are a few others that have this same problem.

I'll post a patch here shortly.
 
WWW  
IP Logged  
 Reply #3 - Jun 25th, 2009 at 1:19am
There are no actions to perform.  

cepheid 
Senior Member
****
Offline
Posts: 516


None
Re: "last post" weirdness on newly set-up forum
Patch ready ... http://dev.3phase.com/yabb/menudef.patch

In looking at those files, I am overcome with how redundant they are.  There really only needs to be a single Menu.def file that builds the proper style as needed.  Carsten attempted this with his mod but his file was too simple, and required all strings to be built from scratch on every call.  However, there is a proper middle-ground, where the menu doesn't have to be built with a procedure each time, yet we can have a single unified file where only a single line needs to be edited, not three.

I'll work on this as I can.
 
WWW  
IP Logged  
 Reply #4 - Jun 25th, 2009 at 4:36am
There are no actions to perform.  

Jet Li 
Legacy Dev Team
Development Team
****
Offline
Posts: 6,588
Hong Kong


None
Re: "last post" weirdness on newly set-up forum
cepheid wrote on Jun 25th, 2009 at 1:19am:
Patch ready

its alrady fixed. Get new files from SVN and save once Style Sheet again. Smiley
 
...
PM me for YaBB Installation Service
WWW Jet Li 100000788351637  
IP Logged  
 Reply #5 - Jun 25th, 2009 at 4:43am
There are no actions to perform.  

cepheid 
Senior Member
****
Offline
Posts: 516


None
Re: "last post" weirdness on newly set-up forum
Jet Li wrote on Jun 25th, 2009 at 4:36am:
Get new files from SVN and save once Style Sheet again.

Jet Li, this was from a forum I set up only a few hours ago, using the very latest SVN.  No changes have been made to SVN since I downloaded and installed the forum.  Looking on SVN, the default Menu*.def files still have this problem.

I should not be required to save the Style Sheet in order to get a working forum - it should work out of the box.  This patch fixes the default Menu*.def files.  It should be applied.
 
WWW  
IP Logged  
 Reply #6 - Jun 26th, 2009 at 6:38pm
There are no actions to perform.  

deti 
Legacy Dev Team
Development Team
****
Offline
Posts: 2,650
Prien am Chiemsee, Germany


None
Re: [SVN] "last post" weirdness on newly set-up forum
New Variables/Menu[1|2|3].def in SVN.
 
Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
WWW  
IP Logged  
Page Index Toggle Pages: 1
Topic Tools
 

Get Yet another Bulletin Board at SourceForge.net. Fast, secure and Free Open Source software downloads Support This Project BoardMod - YaBB features and templates YaBB Codex - support on installation and usage YaBB Toolbar for your browser

YaBB Facebook Group Page

Vulnerability Scanner

Valid RSS Valid XHTML Valid CSS Powered by Perl
YaBB Chat and Support Community » Powered by YaBB 3.0 Beta!
YaBB Forum Software © 2000-2011. All Rights Reserved.