Page Index Toggle Pages: 1
Topic Tools
Normal Topic stars when making new member group or editing (Read 2,286 times)
Corey Chapman
YaBB Administrator
*****
Offline



Posts: 10,024
Location: Rock Hill, South Carolina

None
stars when making new member group or editing
Jun 25th, 2009 at 3:57am
Post Tools
When you make or edit a member group, there is a dropdown to choose the star used for it.  This isn't a bug, but more of an oversight.  It should show the stars to the right of that dropdown so you know what it looks like.  This should change as you scroll through the list like avatars do in the profile.
  

Back to top
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: stars when making new member group or editing
Reply #1 - Jun 25th, 2009 at 5:41am
Post Tools
Apply the patch below and it should fix that right up for you.

http://dev.3phase.com/yabb/membergroups.patch

(It works even when the "other" star is selected and a URL given.  I tested this on my forum, though if you find a bug, let me know.)
« Last Edit: Jun 26th, 2009 at 12:21am by cepheid »  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: stars when making new member group or editing
Reply #2 - Jun 26th, 2009 at 6:22pm
Post Tools
Added to SVN.

Thanks for the code cepheid!
I had to modify it a bit because if you were on yabb21 template no stars were displayed.
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: stars when making new member group or editing
Reply #3 - Jun 26th, 2009 at 7:04pm
Post Tools
deti wrote on Jun 26th, 2009 at 6:22pm:
I had to modify it a bit because if you were on yabb21 template no stars were displayed.

Right, because the regexp code to find the correct image won't work on dynamic Javascript, unless all the images were preloaded... oops.  Forgot about that.

I see you had to basically hack together a Javascript version of that ImgLoc code!  But you only need to check that if the selection isn't "other" ... if it's "other" then it relies on the external URL.  So you can save a little bit of processing by not checking that.  (No big deal either way, given how rarely this will be called.)
  
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: 1
Topic Tools
 
  « Board Index ‹ Board  ^Top