Page Index Toggle Pages: 1
Topic Tools
Normal Topic Facebook usernames don't work in profile (Read 4,423 times)
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Facebook usernames don't work in profile
Reply #8 - Jun 26th, 2009 at 8:04pm
Post Tools
Uuups, I forgot to fix the file

cgi-bin/yabb2/Sources/Load.pl

Now new in SVN.


Help for Help-files appreciated!!!
« Last Edit: Jun 26th, 2009 at 8:05pm by deti »  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Facebook usernames don't work in profile
Reply #7 - Jun 26th, 2009 at 7:54pm
Post Tools
deti wrote on Jun 26th, 2009 at 7:30pm:
Thanks cepheid.

No problem.  The subtext will need to be modified, too, though... since the URL may or may not be the "id=" one, the gray text above the box may or may not be correct.  The help files also need an update to explain that either usernames or numeric IDs work.

If you don't get to it first, I'll try to do that later today.
« Last Edit: Jun 26th, 2009 at 7:56pm by cepheid »  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Facebook usernames don't work in profile
Reply #6 - Jun 26th, 2009 at 7:30pm
Post Tools
New Profile.pl in SVN.

Thanks cepheid.
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Facebook usernames don't work in profile
Reply #5 - Jun 26th, 2009 at 7:11pm
Post Tools
For numeric IDs, it looks just like it is coded now (with the profile.php/id=XXX)... for usernames, it looks like http://www.facebook.com/username (so no id=XXX).

The simplest fix is probably something like:
Code
Select All
$facebookURL = "http://www.facebook.com/" . (($fbID !~ m~\D+~) ? "profile.php/id=" : "") . $fbID 



That way, if the ID is entirely numeric, it uses the id= version of the URL... if the ID contains any non-numeric characters, it's a username and the id= stuff is omitted.  Obviously the variable names need to be the correct ones... I haven't looked through the code to find the right ones. Smiley
« Last Edit: Jun 26th, 2009 at 7:14pm by cepheid »  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Facebook usernames don't work in profile
Reply #4 - Jun 26th, 2009 at 6:42pm
Post Tools
How must the URL look like for numeric id's and how for non numeric?
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
JonB
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 3,789
Location: Land of the Blazing Sun!

YaBB 2.6.0
Re: Facebook usernames don't work in profile
Reply #3 - Jun 25th, 2009 at 11:59am
Post Tools
I agree, and I also looked for a Maintenance "place", we probably need a Board for 2.x maintenance as there will be others.

- BUT (LOL) you didn't post as "Not a Bug".  Smiley

Smiley




  

I find your lack of faith disturbing.
Back to top
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Facebook usernames don't work in profile
Reply #2 - Jun 25th, 2009 at 10:11am
Post Tools
JonB wrote on Jun 25th, 2009 at 10:09am:
Duly noted but not a bug IMO. It doesn't affect YaBB functionality or cause any errors.

No, but we don't really have a forum for "the functionality has changed and needs updating" ... so this was the best place for it.  I think.

Heck, even Corey posted a "not a bug" thread in the Bugs forum last night!
« Last Edit: Jun 25th, 2009 at 10:11am by cepheid »  
Back to top
WWW  
IP Logged
 
JonB
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 3,789
Location: Land of the Blazing Sun!

YaBB 2.6.0
Re: Facebook usernames don't work in profile
Reply #1 - Jun 25th, 2009 at 10:09am
Post Tools
Ummm -

Duly noted but not a bug IMO. It doesn't affect YaBB functionality or cause any errors.

Its not a 'bug' when your software needs a fix due to a change in a third parties site.  It should go on a 'could use a fix when possible' suggestions for maintenance list.

Just not a bug (what NO 'bug' Smiley?)


http://knol.google.com/k/vinayak-rao/bug-life-cycle-defect-reporting-in-sdlc/2q3...


Smiley
  

I find your lack of faith disturbing.
Back to top
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Facebook usernames don't work in profile
Jun 25th, 2009 at 6:24am
Post Tools
Facebook now has usernames, not just numeric IDs, but putting in a username in the profile field doesn't work - the resulting URL isn't valid (Facebook just redirects to the home page).

There should probably be a checkbox for "numeric ID" versus "username" ... either that, or just check to see: if the field is entirely numeric, use the "id=XXX" form of the URL; otherwise, use the username portion.

(It's actually hard for someone who has picked a username to even find their numeric ID!)

The help files would need updating, too.
  
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: 1
Topic Tools
 
  « Board Index ‹ Board  ^Top