Page Index Toggle Pages: 1 [2] 3 4 5
Topic Tools
Very Hot Topic (More than 25 Replies) Optimizing .lng files (Read 19,782 times)
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Optimizing .lng files
Reply #45 - Jul 7th, 2009 at 11:31am
Post Tools
@ cepheid

I'm using Notepad++, what must I do to apply the patch automatically?

Is there a program to apply the patch automatically?
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
OH Eng
Past Team Members
Documentation Team
Offline



Posts: 4,026
Location: Pensacola, Florida USA
Re: Optimizing .lng files
Reply #44 - Jul 7th, 2009 at 5:05am
Post Tools
Bowling with Heineken minikegs (as the bowling ball) takes hours and hours of practice.   Wink Grin Grin
  

 
Back to top
 
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Optimizing .lng files
Reply #43 - Jul 7th, 2009 at 5:01am
Post Tools
Jet Li wrote on Jul 7th, 2009 at 4:59am:
Not only Feature. Busy in Real Life.

Blasphemy! Wink
  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Optimizing .lng files
Reply #42 - Jul 7th, 2009 at 4:59am
Post Tools
cepheid wrote on Jul 7th, 2009 at 4:47am:
I know you're busy with other features,

Not only Feature. Busy in Real Life. Tongue
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Optimizing .lng files
Reply #41 - Jul 7th, 2009 at 4:47am
Post Tools
Would one of the devs be so kind as to apply the above two patches?  I know you're busy with other features, I just want to make sure that the underlying files don't change so much that the patch becomes invalid. Smiley
  
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Optimizing .lng files
Reply #40 - Jul 3rd, 2009 at 3:03am
Post Tools
Another new patch file available, for BoardIndex.lng:

http://dev.3phase.com/yabb/patches/boardindex_lng.patch

This also includes minor edits to BoardIndex.pl and ajax.js for cosmetic improvements (and two cosmetic bug fixes), along with a tiny edit to BoardIndex.template (for both default and yabb21 templates) for cosmetics.

(I noticed that the SVN copies of BoardIndex.pl and the template files were modified while I was working on them, but this patch should apply cleanly... the changes to SVN were minor and should not disrupt the patch.  I think.)
« Last Edit: Jul 3rd, 2009 at 3:13am by cepheid »  
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Optimizing .lng files
Reply #39 - Jul 2nd, 2009 at 10:51am
Post Tools
Next patch available, for Backup.lng:

http://dev.3phase.com/yabb/patches/backup_lng.patch

A whole lot of edits on this one, mostly to improve wording and add extra information and instructions.

I also made a few tiny edits to Admin/Backup.pl - two are cosmetic (for clarity), the other is to reduce a tiny bit of code redundancy.
  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Optimizing .lng files
Reply #38 - Jul 1st, 2009 at 3:15pm
Post Tools
cepheid wrote on Jul 1st, 2009 at 7:01am:
Please apply

Done again. Grin Wink

New
cgi-bin/yabb2/Languages/English/Admin.lng
in SVN.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Optimizing .lng files
Reply #37 - Jul 1st, 2009 at 7:01am
Post Tools
Jet Li wrote on Jun 30th, 2009 at 4:21pm:
Done.

Argh, OOPS.  My patch file was incomplete.  I stupidly ran the diff with -i and thereby ignored any capitalization fixes... d'oh! Embarrassed

Please apply http://dev.3phase.com/yabb/patches/admin_lng3.patch ... this has the corrections missing from the previous patch.  I feel like an idiot!
  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Optimizing .lng files
Reply #36 - Jun 30th, 2009 at 4:21pm
Post Tools
cepheid wrote on Jun 30th, 2009 at 10:13am:
OK, it's ready.

Done.

New
cgi-bin/yabb2/Admin/ManageBoards.pl
cgi-bin/yabb2/Languages/English/Admin.lng

in SVN.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Optimizing .lng files
Reply #35 - Jun 30th, 2009 at 4:08pm
Post Tools
deti wrote on Jun 30th, 2009 at 11:39am:
I like Guest, Admin, Global Mod (not Gmod or GlobalMod), and Mod with capital letters.

That's what I did in the current iteration.

deti wrote on Jun 30th, 2009 at 11:39am:
membergroups, user, member and other "special" titles could also be in itlaic without capitals I think.

I personally don't think we should bother with italics, especially for "user" and "member."  Those just follow in plain English, I think.  "Member group" is kind of a tough one, but it should be two words I think because that way we can just call it Groups for short... I'm OK with capitalizing it.  I'd prefer to avoid the italics, though - I think it would just be distracting, personally.

deti wrote on Jun 30th, 2009 at 11:39am:
There are/were some places with FA (ForumAdministrator), can you fix that to Admin or Administrator?

I didn't see any "FA" or "ForumAdministrator" in any of the English .lng files.  There is one instance of "Forum Administrator" (with a space) in Admin.lng, but it's a title tag and I think it's OK there (since it's 2 words, not one).
  
Back to top
WWW  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: Optimizing .lng files
Reply #34 - Jun 30th, 2009 at 11:39am
Post Tools
cepheid wrote on Jun 30th, 2009 at 12:22am:
Let's come up with a standard together, that all of us are happy about, and I can then apply that standard to all the files so everything is uniform.

I like Guest, Admin, Global Mod (not Gmod or GlobalMod), and Mod with capital letters.

membergroups, user, member and other "special" titles could also be in itlaic without capitals I think.

There are/were some places with FA (ForumAdministrator), can you fix that to Admin or Administrator?
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Optimizing .lng files
Reply #33 - Jun 30th, 2009 at 10:13am
Post Tools
Jet Li wrote on Jun 30th, 2009 at 4:47am:
I will wait for it.

OK, it's ready.

http://dev.3phase.com/yabb/patches/admin_lng2.patch

I incorporated most of OH Eng's corrections, above, plus a whole lot of other ones.  I tried to get a standardized capitalization scheme going... Guest, Admin, Global Mod, and Mod are capitalized, but user and member are not, because those are not "special" titles.  I also changed capitalization on a few other thing (Post, Email, etc.)  It's still not 100% consistent, but it should be a lot better than it was.

The patch also includes a tiny update to Admin/ManageBoards.pl, specifically to reorder the moderator settings under "Optional Settings" ... because boards don't actually require any moderator selection, and will function just fine even if no moderator is selected.

I still have not removed any unused entries, btu I identified a lot more... there are at least 15-20 lines that can be removed entirely, and probably more than that.

Hope everyone is happy with this batch... I'd like to move on to the next few files, but I want to make sure I'm doing this in a standard way, so once we're all agreed on this file, I'll move on to the next one(s). Smiley
  
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Optimizing .lng files
Reply #32 - Jun 30th, 2009 at 4:47am
Post Tools
@ OH Eng

I will change later today. Smiley

cepheid wrote on Jun 30th, 2009 at 12:22am:
others into a true patch file to make it easier for the devs to apply.Devs, look for it soon.

I will wait for it. Smiley
« Last Edit: Jun 30th, 2009 at 4:49am by Jet Li »  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
cepheid
Senior Member
****
Offline



Posts: 516
Re: Optimizing .lng files
Reply #31 - Jun 30th, 2009 at 12:22am
Post Tools
OH Eng wrote on Jun 29th, 2009 at 11:40pm:
No one is really sure about capitals.

At least I'm not the only one! Smiley  Perhaps we should work out a rule so that I can apply it uniformly across all the files?  Proper names do require capitals but I don't think "user," "admin," etc. are proper names more than they are designations.  We normally don't capitalize things like "manager" unless it's a specific title (like on a business card), hence I would probably not capitalize "user," etc.

We do want to distinguish it from the rest of the code, I suppose, but I'd be perfectly happy to just remove all the caps.  What do you think?  Let's come up with a standard together, that all of us are happy about, and I can then apply that standard to all the files so everything is uniform.

OH Eng wrote on Jun 29th, 2009 at 11:40pm:
I don't know how to make it simpler...

That's why I used "restrict," but you're right that it's still confusing.  I'll try to think of something better.

OH Eng wrote on Jun 29th, 2009 at 11:40pm:
Show users currently replying to or viewing the Topic to:'

I'd reverse "viewing" and "replying to," just because one is more common, but that works just fine, yeah.

I'll work up your changes plus these others into a true patch file to make it easier for the devs to apply.  Devs, look for it soon. Smiley
« Last Edit: Jun 30th, 2009 at 12:25am by cepheid »  
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: 1 [2] 3 4 5
Topic Tools
 
  « Board Index ‹ Board  ^Top