Page Index Toggle Pages: 1
Topic Tools
Normal Topic Title attributes for "more smilies" (Read 1,403 times)
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Title attributes for "more smilies"
Reply #1 - Dec 31st, 2009 at 4:25pm
Post Tools
New Post.pl in CVS.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Jens Brix Christiansen
YaBB Newcomer
*
Offline



Posts: 26
Location: Frederiksberg, Denmark
Title attributes for "more smilies"
Nov 15th, 2009 at 5:36pm
Post Tools
YaBB 2.4, post.pl, line 409.

The smilies in the list "$moresmilieslist" do not get the title attribute set. In Firefox this implies that there is no pop-up tip for these smilies, unlike the built-in smilies that appear on the same line. The alt attribute is set properly, so in MSIE, there will be a pop-up tip.

If this is acknowledged as bug (admittedly a very minor one), the fix is to change line 409 in post.pl from

Code
Select All
			$moresmilieslist .= qq~				document.write('<img src="$tmpurl" align="bottom" alt="$SmilieDescription[$i]" border="0" onclick="javascript: MoreSmilies($i);" style="cursor: pointer;" />$SmilieLinebreak[$i] ');\n~; 


to
Code
Select All
			$moresmilieslist .= qq~				document.write('<img src="$tmpurl" align="bottom" alt="$SmilieDescription[$i]" title="$SmilieDescription[$i]" border="0" onclick="javascript: MoreSmilies($i);" style="cursor: pointer;" />$SmilieLinebreak[$i] ');\n~; 



If the added smilies are elaborated elsewhere in the code, it might be worthwhile to consider whether this fix should be applied there too.
  
Back to top
 
IP Logged
 
Page Index Toggle Pages: 1
Topic Tools
 
  « Board Index ‹ Board  ^Top