Page Index Toggle Pages: 1
Topic Tools
Normal Topic postlayout variable conversion (Read 1,378 times)
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: postlayout variable conversion
Reply #2 - Jan 1st, 2010 at 12:37pm
Post Tools
@ Jens Brix Christiansen

New
Setup.pl
in CVS.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
deti
Legacy Dev Team
Development Team
****
Offline



Posts: 2,650
Location: Prien am Chiemsee, Germany
Re: postlayout variable conversion
Reply #1 - Dec 8th, 2009 at 12:29pm
Post Tools
Right! Good catch Jens!
  

Was immer Du tun kannst
oder erträumst tun zu können,
beginne es.
Kühnheit besitzt Genie,
Macht und magische Kraft.
Beginne es jetzt.
Whatever you can do
or dream you can,
begin it.
Boldness has genius,
power and magic in it.
Begin it now.
J. W. Goethe
Back to top
WWW  
IP Logged
 
Jens Brix Christiansen
YaBB Newcomer
*
Offline



Posts: 26
Location: Frederiksberg, Denmark
postlayout variable conversion
Dec 7th, 2009 at 3:58pm
Post Tools
When converting from YaBB 1 Gold, SP1.4 to YaBB 2.4, the variable postlayout is initialized like this for all members:

Code
Select All
'postlayout',"|0" 


When the member then does his first post on the converted board, post.pl interprets this as containing a font size of 0, which is then defaulted to the minimum font size (6 pt, unless the administrator has changed that minimum).

This is probably a bug in the conversion process, where the string "|0" should only be appended to the postlayout if it is non-empty to begin with (i.e. if the conversion is from some later version of YaBB).

I changed line 1318 and line 1438 in Setup.pl from
Code
Select All
		'postlayout'    => "$settings[31]|0", 


to
Code
Select All
		'postlayout'    => ($settings[31] ? "$settings[31]|0" : ''), 


which solved the problem for my conversion.

I am not sure whether this solution will also work for conversions from versions of YaBB that actually have a postlayout variable to convert.
  
Back to top
 
IP Logged
 
Page Index Toggle Pages: 1
Topic Tools
 
  « Board Index ‹ Board  ^Top