Page Index Toggle Pages: 1
Topic Tools
Normal Topic A couple of smiley bugs (Read 2,544 times)
batchman
Support Team
****
Offline



Posts: 376
Location: Orlando, FL
A couple of smiley bugs
Jan 15th, 2010 at 5:13am
Post Tools
Two smiley bugs that could use correcting ....

First off, in the add  more smilies panel, there is a check-box you can click to say that you want to have a line break after a particular smiley, to prevent the line of smiles from getting too long in the post message area.

Problem is, that check box doesn't only affect the post message area. Every time you post that smiley in a message, it puts a line break after it.

I'm guessing this wasn't the intended effect.

Secondly, if in the smiley description field (where you say what text will show on mouseover while writing your post) you place a ! or a ', it accepts it without any sort of complaint, but your row(s) of smilies disappear. Shouldn't it either tell you it has a problem with those symbols, and not allow you to use them, or work properly when you use them?

I would guess the same problems would exist in Y3.

(What can I say, I was adding some more smilies tonight.)
  
Back to top
 
IP Logged
 
batchman
Support Team
****
Offline



Posts: 376
Location: Orlando, FL
Re: A couple of smiley bugs
Reply #1 - Jan 20th, 2010 at 9:37pm
Post Tools
Nobody can even verify these? Is it just my forum these happen?
  
Back to top
 
IP Logged
 
Captain John
Ex Member


Re: A couple of smiley bugs
Reply #2 - Jan 21st, 2010 at 12:09am
Post Tools
batchman ...
and it seems so (only yours) ... see attachments
« Last Edit: Jan 21st, 2010 at 12:10am by »  

EasyCapture7.png ( 11 KB | 76 Downloads )
EasyCapture7.png
EasyCapture6.png ( 7 KB | 103 Downloads )
EasyCapture6.png
Back to top
 
IP Logged
 
Carsten
Ex Member


Re: A couple of smiley bugs
Reply #3 - Jan 21st, 2010 at 3:10am
Post Tools
I can confirm the line break bug - see attachment

Your second problem i can't reproduce - ! in description is working for me.
  

smilebug.png ( 15 KB | 77 Downloads )
smilebug.png
Back to top
 
IP Logged
 
Captain John
Ex Member


Re: A couple of smiley bugs
Reply #4 - Jan 21st, 2010 at 6:20pm
Post Tools
batchman wrote on Jan 15th, 2010 at 5:13am:
Every time you post that smiley in a message, it puts a line break after it.


Well of course, the carriage return (line break) will repeat for that specific smilie.  It's saved in Admin Center settings !  Nothing saved is "temporary" or one time use.

batchman wrote on Jan 15th, 2010 at 5:13am:
to prevent the line of smiles from getting too long in the post message area.


That wasn't the reason for the option ...
« Last Edit: Jan 21st, 2010 at 6:23pm by »  
Back to top
 
IP Logged
 
batchman
Support Team
****
Offline



Posts: 376
Location: Orlando, FL
Re: A couple of smiley bugs
Reply #5 - Jan 21st, 2010 at 9:23pm
Post Tools
Quote:
That wasn't the reason for the option ...


Oh? What was the reason for it?

If that wasn't the reason, then I need to find a way to do what I thought this was supposed to do ... not add a line return to the smiley, itself, but to allow me to choose points at which to break the displayed line of smileys in the message post area, to keep things halfway neat and clean, layout-wise.

Thanks, Carsten, for verifying for me ... but it looks like it may not be a bug, I just may not understand what the point of the 'feature' was.
« Last Edit: Jan 21st, 2010 at 9:25pm by batchman »  
Back to top
 
IP Logged
 
Carsten
Ex Member


Re: A couple of smiley bugs
Reply #6 - Jan 22nd, 2010 at 12:05am
Post Tools
I don't remember any discussion about the reason for the line break option but like batchman i fail to see any reason other than the cosmetic layout in the message post page.

The fix:

In YaBBC.pl find this line and remove the highlighted part:
Code
Select All
		$message =~ s~\Q$tmpcode\E~<img src="$tmpurl" border="0" alt="$SmilieDescription[$count]" title="$SmilieDescription[$count]" />$SmilieLinebreak[$count]~g;
 



That said, this is in my opinion a rather clumsy way to manage the layout problem. The better way imho is to put a div around the smilie bar. In Post.pl find the code and add the highlighted (2 lines) and then forget about adding line breaks to any smilies (same approach in InstantMessage.pl):
Code
Select All
			document.write("<div style='float: left; width: 440px;'>");
			document.write("<img src='$imagesdir/smiley.gif' onclick='smiley();' "+HAND+" align='bottom' alt='$post_txt{'287'}' title='$post_txt{'287'}' border='0'> ");
			document.write("<img src='$imagesdir/wink.gif' onclick='wink();' "+HAND+" align='bottom' alt='$post_txt{'292'}' title='$post_txt{'292'}' border='0'> ");
			document.write("<img src='$imagesdir/cheesy.gif' onclick='cheesy();' "+HAND+" align='bottom' alt='$post_txt{'289'}' title='$post_txt{'289'}' border='0'> ");
			document.write("<img src='$imagesdir/grin.gif' onclick='grin();' "+HAND+" align='bottom' alt='$post_txt{'293'}' title='$post_txt{'293'}' border='0'> ");
			document.write("<img src='$imagesdir/angry.gif' onclick='angry();' "+HAND+" align='bottom' alt='$post_txt{'288'}' title='$post_txt{'288'}' border='0'> ");
			document.write("<img src='$imagesdir/sad.gif' onclick='sad();' "+HAND+" align='bottom' alt='$post_txt{'291'}' title='$post_txt{'291'}' border='0'> ");
			document.write("<img src='$imagesdir/shocked.gif' onclick='shocked();' "+HAND+" align='bottom' alt='$post_txt{'294'}' title='$post_txt{'294'}' border='0'> ");
			document.write("<img src='$imagesdir/cool.gif' onclick='cool();' "+HAND+" align='bottom' alt='$post_txt{'295'}' title='$post_txt{'295'}' border='0'> ");
			document.write("<img src='$imagesdir/huh.gif' onclick='huh();' "+HAND+" align='bottom' alt='$post_txt{'296'}' title='$post_txt{'296'}' border='0'> ");
			document.write("<img src='$imagesdir/rolleyes.gif' onclick='rolleyes();' "+HAND+" align='bottom' alt='$post_txt{'450'}' title='$post_txt{'450'}' border='0'> ");
			document.write("<img src='$imagesdir/tongue.gif' onclick='tongue();' "+HAND+" align='bottom' alt='$post_txt{'451'}' title='$post_txt{'451'}' border='0'> ");
			document.write("<img src='$imagesdir/embarassed.gif' onclick='embarassed();' "+HAND+" align='bottom' alt='$post_txt{'526'}' title='$post_txt{'526'}' border='0'> ");
			document.write("<img src='$imagesdir/lipsrsealed.gif' onclick='lipsrsealed();' "+HAND+" align='bottom' alt='$post_txt{'527'}' title='$post_txt{'527'}' border='0'> ");
			document.write("<img src='$imagesdir/undecided.gif' onclick='undecided();' "+HAND+" align='bottom' alt='$post_txt{'528'}' title='$post_txt{'528'}' border='0'> ");
			document.write("<img src='$imagesdir/kiss.gif' onclick='kiss();' "+HAND+" align='bottom' alt='$post_txt{'529'}' title='$post_txt{'529'}' border='0'> ");
			document.write("<img src='$imagesdir/cry.gif' onclick='cry();' "+HAND+" align='bottom' alt='$post_txt{'530'}' title='$post_txt{'530'}' border='0'> ");$moresmilieslist
			document.write("</div>"); 

« Last Edit: Jan 22nd, 2010 at 12:49am by »  
Back to top
 
IP Logged
 
batchman
Support Team
****
Offline



Posts: 376
Location: Orlando, FL
Re: A couple of smiley bugs
Reply #7 - Jan 22nd, 2010 at 10:22pm
Post Tools
As always, Carsten, you have the perfect solution. Nice, simple, and the problem with smileys breaking text where they shouldn't is gone!

Thanks for always being willing to share your knowledge ... I can't tell you how much it has been appreciated over the years!
  
Back to top
 
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: A couple of smiley bugs
Reply #8 - Jan 23rd, 2010 at 9:51am
Post Tools
New
Sources\Post.pl
Sources\YaBBC.pl

in CVS.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Page Index Toggle Pages: 1
Topic Tools
 
  « Board Index ‹ Board  ^Top