Page Index Toggle Pages: 1
Topic Tools
Hot Topic (More than 10 Replies) [Minor]Firefox 3.6 fails test(navigator.userAgent) (Read 4,399 times)
Matt Siegman
YaBB Legends (Inactive)
*
Offline



Posts: 3,380
Location: Wichita, KS
Re: [Minor]Firefox 3.6 fails test(navigator.userAgent)
Reply #12 - Mar 30th, 2010 at 10:22pm
Post Tools
Sorry, my bad.
  

-- Matt Siegman 8) Wish List
Back to top
 
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: [Minor]Firefox 3.6 fails test(navigator.userAgent)
Reply #11 - Mar 30th, 2010 at 5:04am
Post Tools
Then not move so fast. Better you let me move if it done. Otherwise I lost my history for my ToDo List to fix for YaBB 2.5/3.0
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Captain John
Ex Member


Re: [Minor]Firefox 3.6 fails test(navigator.userAgent)
Reply #10 - Mar 30th, 2010 at 5:02am
Post Tools
That's why the question in reply #7
  
Back to top
 
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: [Minor]Firefox 3.6 fails test(navigator.userAgent)
Reply #9 - Mar 30th, 2010 at 4:57am
Post Tools
New
Sources/InstantMessage.pl
Sources/Post.pl

in CVS.

@ Captain John

Don't move so fast. If it not was in CVS!
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Matt Siegman
YaBB Legends (Inactive)
*
Offline



Posts: 3,380
Location: Wichita, KS
Re: [Minor]Firefox 3.6 fails test(navigator.userAgent)
Reply #8 - Mar 30th, 2010 at 1:39am
Post Tools
I thought Jet put it in? I don't have CVS on this computer, can someone verify that this made it in?
  

-- Matt Siegman 8) Wish List
Back to top
 
IP Logged
 
Captain John
Ex Member


Re: [Minor]Firefox 3.6 fails test(navigator.userAgent)
Reply #7 - Mar 30th, 2010 at 1:28am
Post Tools
Jet Li wrote on Mar 26th, 2010 at 11:24am:
Thnx @ Matt Siegman

I have tested on my CVS Testforum.

IE 8 = OK
FF 3.6.2 = OK
Google Chrome 4.1.249.1042 = OK
Opera 10.51 = Doesn't show
Safari 4.0.5 = OK


in CVS ??
  
Back to top
 
IP Logged
 
Matt Siegman
YaBB Legends (Inactive)
*
Offline



Posts: 3,380
Location: Wichita, KS
Re: [Minor]Firefox 3.6 fails test(navigator.userAgent)
Reply #6 - Mar 30th, 2010 at 1:02am
Post Tools
Well, in that case it seems like this is fixed Smiley
  

-- Matt Siegman 8) Wish List
Back to top
 
IP Logged
 
Captain John
Ex Member


Re: [Minor]Firefox 3.6 fails test(navigator.userAgent)
Reply #5 - Mar 27th, 2010 at 1:52am
Post Tools
Test Test

No Opera does not support key board short cuts ..
  
Back to top
 
IP Logged
 
Matt Siegman
YaBB Legends (Inactive)
*
Offline



Posts: 3,380
Location: Wichita, KS
Re: [Minor]Firefox 3.6 fails test(navigator.userAgent)
Reply #4 - Mar 26th, 2010 at 10:33pm
Post Tools
Does Opera support the hotkeys?
  

-- Matt Siegman 8) Wish List
Back to top
 
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Firefox 3.6 fails test(navigator.userAgent)
Reply #3 - Mar 26th, 2010 at 11:24am
Post Tools
Thnx @ Matt Siegman

I have tested on my CVS Testforum.

IE 8 = OK
FF 3.6.2 = OK
Google Chrome 4.1.249.1042 = OK
Opera 10.51 = Doesn't show
Safari 4.0.5 = OK
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Matt Siegman
YaBB Legends (Inactive)
*
Offline



Posts: 3,380
Location: Wichita, KS
Re: Firefox 3.6 fails test(navigator.userAgent)
Reply #2 - Mar 26th, 2010 at 2:14am
Post Tools
This appears to only target 3.6, the problem is that it is looking for another '.' character. I would classify as minor.

The text also doesn't show in Chrome, which works the same as Firefox.

I recommend the following fix:

Code
Select All
} else if (/Firefox\\/[2-9]/.test(navigator.userAgent) || /Chrome/.test(navigator.userAgent)) {
 

« Last Edit: Mar 26th, 2010 at 2:16am by Matt Siegman »  

-- Matt Siegman 8) Wish List
Back to top
 
IP Logged
 
Captain John
Ex Member


Re: Firefox 3.6 fails test(navigator.userAgent)
Reply #1 - Mar 26th, 2010 at 1:35am
Post Tools
In FF3.6.2 ... I see (attached)
  

buttonshorts.jpg ( 7 KB | 127 Downloads )
buttonshorts.jpg
Back to top
 
IP Logged
 
Benjamin
Junior Member
**
Offline



Posts: 89
[Minor]Firefox 3.6 fails test(navigator.userAgent)
Jan 28th, 2010 at 9:15pm
Post Tools
With Firefox 3.6 (only tested with Windows) there is no info text under the buttons about shortcuts. The reason is the match in Post.pl line 1308
Code
Select All
} else if (/Firefox\\/[2-9]\\.\\d+\\.\\d+/.test(navigator.userAgent)) { 


It should be
Code
Select All
} else if (/Firefox\\/[2-9]\\.\\d+/.test(navigator.userAgent)) { 


or just
Code
Select All
} else if (/Firefox\\/[2-9]/.test(navigator.userAgent)) { 


since version 3.6 contains "Firefox/3.6" and not "Firefox/3.6.0" in the userAgent string. Maybe different with Linux.
Same code in InstantMessage.pl line 1088.

Code has not been tested yet.
« Last Edit: Mar 26th, 2010 at 7:09pm by »  
Back to top
 
IP Logged
 
Page Index Toggle Pages: 1
Topic Tools
 
  « Board Index ‹ Board  ^Top