Page Index Toggle Pages: [1] 2 
Topic Tools
Hot Topic (More than 10 Replies) Images with parameter in quotes (Read 8,429 times)
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Images with parameter in quotes
Reply #15 - Dec 26th, 2010 at 12:05pm
Post Tools
Applied on my Dev Forum. Patch will be in next Beta Package and in SVN. Smiley
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Carsten
Ex Member


Re: Images with parameter in quotes
Reply #14 - Nov 29th, 2010 at 3:38pm
Post Tools
Bug in images not displayed in quotes - see edited code in reply #2.
« Last Edit: Nov 29th, 2010 at 3:39pm by »  
Back to top
 
IP Logged
 
Carsten
Ex Member


Re: Images with parameter in quotes
Reply #13 - Mar 14th, 2010 at 5:30pm
Post Tools
Jet Li wrote on Mar 14th, 2010 at 5:18pm:
oups. I had forgot add ; after style="width: 90% in English Post.lng


@$>XX%&"%;;?(...  Grin

hehe, happens in the best of families...
  
Back to top
 
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Images with parameter in quotes
Reply #12 - Mar 14th, 2010 at 5:18pm
Post Tools
oups. I had forgot add ; after style="width: 90% in English Post.lng. Lips Sealed

New
Languages\English\Post.lng
Sources\YaBBC.pl

in CVS.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Carsten
Ex Member


Re: Images with parameter in quotes
Reply #11 - Mar 14th, 2010 at 5:03pm
Post Tools
Hmmmm - i just took the time to test with your (german) text variables.


1. With escaped double quote marks and 'overflow: auto': No borders - exactly as you had first.

2. With un-escaped double quote marks and 'overflow: auto': Borders ok and images inside quote box - as it should be

3. With un-escaped double quote marks and without 'overflow: auto': Borders ok and images outside quote box


No. 2. is how it should be and working perfectly for me in 5 main browsers.
« Last Edit: Mar 14th, 2010 at 5:06pm by »  
Back to top
 
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Images with parameter in quotes
Reply #10 - Mar 14th, 2010 at 4:45pm
Post Tools
Yes. Smiley Quote have border now. Only with or without  overflow: auto; , image still outside quote.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Carsten
Ex Member


Re: Images with parameter in quotes
Reply #9 - Mar 14th, 2010 at 4:39pm
Post Tools
Did you remove all the backslashes from (4 in each): '599', '599_d', '600', '600_d', '600a' and '600a_d'
« Last Edit: Mar 14th, 2010 at 4:40pm by »  
Back to top
 
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Images with parameter in quotes
Reply #8 - Mar 14th, 2010 at 4:35pm
Post Tools
Ok, removed. Image get still outside quote.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Carsten
Ex Member


Re: Images with parameter in quotes
Reply #7 - Mar 14th, 2010 at 4:28pm
Post Tools
Ok - i see you are using single quote marks for the value part - then you should not escape (some) of the double quote marks - can cause unwanted effects. Try and remove the escaping (backslashes) from all the values:
Code
Select All
'599' => '<a class="message" href="QUOTELINK">Quote from AUTHOR</a> on DATE:<br /><div class=\"quote\" style=\"width: 90%; overflow: auto;\">QUOTE</div>', 

  
Back to top
 
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Images with parameter in quotes
Reply #6 - Mar 14th, 2010 at 3:59pm
Post Tools
Yes. On YaBB 2.4 is working. On CVS was same code in YaBBC.pl

Only in Post.lng was changes from this topic and i add your overflow auto.

http://www.yabbforum.com/community/YaBB.pl?num=1244004990

Code
Select All
'599' => '<a class="message" href="QUOTELINK">Quote from AUTHOR</a> on DATE:<br /><div class=\"quote\" style=\"width: 90%; overflow: auto;\">QUOTE</div>',
'599_d' => '<a class="message" href="QUOTELINK">Quote from AUTHOR</a> DATE:<br /><div class=\"quote\" style=\"width: 90%; overflow: auto;\">QUOTE</div>',
'600' => '<a class="message" href="QUOTELINK">AUTHOR wrote</a> on DATE:<br /><div class=\"quote\" style=\"width: 90%; overflow: auto;\">QUOTE</div>',
'600_d' => '<a class="message" href="QUOTELINK">AUTHOR wrote</a> DATE:<br /><div class=\"quote\" style=\"width: 90%; overflow: auto;\">QUOTE</div>',
'600a' => '<a class="message" href="AUTHOR2">AUTHOR</a> wrote on DATE:<br /><div class=\"quote\" style=\"width: 90%; overflow: auto;\">QUOTE</div>',
'600a_d' => '<a class="message" href="AUTHOR2">AUTHOR</a> wrote DATE:<br /><div class=\"quote\" style=\"width: 90%; overflow: auto;\">QUOTE</div>', 

« Last Edit: Mar 14th, 2010 at 4:01pm by Jet Li »  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Carsten
Ex Member


Re: Images with parameter in quotes
Reply #5 - Mar 14th, 2010 at 3:21pm
Post Tools
Hmm - what can i say? I don't have the CVS code.

1:1 - working on my forum: http://www.carsten-dalgaard.dk/cgi-bin/yabb2/YaBB.pl?num=1268579857

Edited:
(back to links in quotes)
« Last Edit: Mar 14th, 2010 at 4:32pm by »  
Back to top
 
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: Images with parameter in quotes
Reply #4 - Mar 14th, 2010 at 9:54am
Post Tools
@ Carsten

I add the changes on my YaBB CVS Testforum, but if change in Post.lng to add overflow auto, the border is gone around quote.

http://www.yabbworld.com/cgi-bin/yabbcvs/YaBB.pl?num=1268559232
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Carsten
Ex Member


Re: Images with parameter in quotes
Reply #3 - Mar 13th, 2010 at 10:57pm
Post Tools
... and the fix for images flowing outside quote box:

In Post.lng find
Code
Select All
'599' => "<b><a class=\"message\" href=\"QUOTELINK\">Quote from AUTHOR</a> on DATE:</b><br /><div class=\"quote\" style=\"width: 90%\">QUOTE</div>",
'600' => "<b><a class=\"message\" href=\"QUOTELINK\">AUTHOR wrote</a> on DATE:</b><br /><div class=\"quote\" style=\"width: 90%\">QUOTE</div>",
'600a' => "<b><a class=\"message\" href=\"AUTHOR2\">AUTHOR</a> wrote on DATE:</b><br /><div class=\"quote\" style=\"width: 90%\">QUOTE</div>", 



and replace with
Code
Select All
'599' => "<b><a class=\"message\" href=\"QUOTELINK\">Quote from AUTHOR</a> on DATE:</b><br /><div class=\"quote\" style=\"width: 90%; overflow: auto;\">QUOTE</div>",
'600' => "<b><a class=\"message\" href=\"QUOTELINK\">AUTHOR wrote</a> on DATE:</b><br /><div class=\"quote\" style=\"width: 90%; overflow: auto;\">QUOTE</div>",
'600a' => "<b><a class=\"message\" href=\"AUTHOR2\">AUTHOR</a> wrote on DATE:</b><br /><div class=\"quote\" style=\"width: 90%; overflow: auto;\">QUOTE</div>", 

  
Back to top
 
IP Logged
 
Carsten
Ex Member


Re: Images with parameter in quotes
Reply #2 - Mar 13th, 2010 at 10:27pm
Post Tools
The fix for images appearing in quotes when they should appear as links should be:

In YaBBC.pl find
Code
Select All
		$tmp_message =~ s~\[img\](?:\s|\t|\n|$hardspace|$char_160)*(https?\:\/\/)*(.+?)(?:\s|\t|\n|$hardspace|$char_160)*\[/img\]~$2$3~isg;
		$tmp_message =~ s~\[img width=(\d+) height=(\d+)\](?:\s|\t|\n|$hardspace|$char_160)*(http\:\/\/)*(.+?)(?:\s|\t|\n|$hardspace|$char_160)*\[\/img\]~$4$5~ig; 


and relpace it with
Code
Select All
		$tmp_message =~ s~\[img (.+?)\]~[img\]~isg;
		$tmp_message =~ s~\[img\](?:\s|\t|\n|$hardspace|$char_160)*(http\:\/\/)*(.+?)(?:\s|\t|\n|$hardspace|$char_160)*\[/img\]~\[url\]$1$2\[\/url\]~isg; 



This is for the Y 2.4 distribution - i don't know if it is the same in CVS.

Still leaves the image flowing outside the (author) quote box when using the align attribute (when setting allows images in quotes).


Edited:
Nov 29th, 2010 at 3:41pm - Just notised a missing space (highlighted) in the fixed code. Strangely the space is there in my original code (where this code is copied/pasted directly from)
« Last Edit: Nov 29th, 2010 at 3:41pm by »  
Back to top
 
IP Logged
 
Captain John
Ex Member


Re: Images with align parameter in quotes
Reply #1 - Mar 13th, 2010 at 9:29pm
Post Tools
verified ...
  
Back to top
 
IP Logged
 
Page Index Toggle Pages: [1] 2 
Topic Tools
 
  « Board Index ‹ Board  ^Top