Page Index Toggle Pages: [1] 2 
Topic Tools
Hot Topic (More than 10 Replies) GreyBox images bugs (Read 9,595 times)
Bill Myers
God Member
Beta Testers
*****
Offline



Posts: 1,557
Location: Los Angeles

YaBB 2.4
Re: GreyBox images bugs
Reply #18 - Apr 13th, 2013 at 4:32pm
Post Tools
Dandello wrote on Apr 13th, 2013 at 3:23pm:
That's what we're doing - that bug is not present in 2.5.2 or 2.5.4.

Way to go! Smiley

I must have mistakenly thought that Emily was using YaBB 2.5.2 instead of an earlier version.

  

Morning, noon, or night, have a great one!

Note: This forum doesn't allow for us to freely edit our posts or topics to make corrections as needed, so please remember to look for subsequent posts if you see any mistakes or outdated information. Sorry for the inconvenience.
Back to top
IP Logged
 
depablo
YaBB Moderators
YaBB Next Team
Beta Testers
***
Offline



Posts: 577
Location: UK

None
Re: GreyBox images bugs
Reply #17 - Apr 13th, 2013 at 4:29pm
Post Tools
SMF and phpBB release bug fix versions and security release updates.

YaBB does the same, although at one point it was like a bit of tumbleweed blowing across the desert.

However I am confident it is starting to climb out of the hole it was in. Carsten, Dandello and others are doing a great job, 2.5.4 is like a Silk purse, once released hopefully the Mod community will update the Mods available.
  

Taking a peek behind the mask Wink
Back to top
 
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 2,128
Location: Earth

YaBB 2.6.0
Re: GreyBox images bugs
Reply #16 - Apr 13th, 2013 at 3:23pm
Post Tools
That's what we're doing - that bug is not present in 2.5.2 or 2.5.4.
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
Bill Myers
God Member
Beta Testers
*****
Offline



Posts: 1,557
Location: Los Angeles

YaBB 2.4
Re: GreyBox images bugs
Reply #15 - Apr 13th, 2013 at 8:43am
Post Tools
Quote:
Miss Emily stated, "So it's a bug in 2.5AE."

From what I can tell, bugs that have been fixed don't get updated into YaBB's code until new versions come out. If so, I guess that's standard practice.

If this is the case ...

Wouldn't it be cool to actually include bug fixes in the downloaded files of YaBB's latest stable version so that people installing YaBB don't have those particular bugs? In other words, keep the latest stable version of YaBB fully updated.

On that note, there's at least one other forum software that pretty much updates itself with the latest bug fixes. If I remember correctly from the last time I used that feature, in its respective Admin Center in a section called "Support Information" there is a link available to admins whenever bug fixes have been implemented so that one's forum software can be quickly, and easily updated with the click of a mouse.

Maybe with a newer version of YaBB at some point, this kind of quick and easy update can be made available.

Just thinking aloud. Wink

  

Morning, noon, or night, have a great one!

Note: This forum doesn't allow for us to freely edit our posts or topics to make corrections as needed, so please remember to look for subsequent posts if you see any mistakes or outdated information. Sorry for the inconvenience.
Back to top
IP Logged
 
JonB
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 3,785
Location: Land of the Blazing Sun!

YaBB 2.6.0
Re: GreyBox images bugs
Reply #14 - Feb 3rd, 2012 at 6:58pm
Post Tools
OTAY !!!

Cheesy
  

I find your lack of faith disturbing.
Back to top
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 2,128
Location: Earth

YaBB 2.6.0
Re: GreyBox images bugs
Reply #13 - Feb 3rd, 2012 at 6:28pm
Post Tools
GOT IT Grin in YaBBC.pl find:
Code
Select All
sub DoUBBC {
  my $msg = _do_ubbc($message);
	$message = $msg;
}

sub _do_ubbc {
  my $message = join "", @_;
	return $message if $ns eq "NS" || $message =~ s/# nosmileys//isg;

	my $image_type = $_[0];
 



and replace it with:
Code
Select All
sub DoUBBC {
	my $image_type = $_[0];

	return $message if $ns eq "NS" || $message =~ s/# nosmileys//isg; 



remember to take out the space between the '#' and 'nosmileys'

I knew it was simple.   Smiley
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 2,128
Location: Earth

YaBB 2.6.0
Re: GreyBox images bugs
Reply #12 - Feb 3rd, 2012 at 5:51pm
Post Tools
Um, I may have forgotten another fix. I know there was a fix and I know I've used it and it works. And it was simple... Let me look over my other versions of YaBBC.pl. I know this one is working: http://www.shadolibrary.org/cgi-bin/yabb2/YaBB.pl?num=1305323498

And I've attached a copy of the YaBBC.pl file that I know for a fact works.
Note that it does use a an extra Perl module that should be standard. If it isn't - open the file in a text editor and replace 'croak' with 'die'.
« Last Edit: Feb 3rd, 2012 at 6:12pm by Dandello »  

YaBBC.zip ( 7 KB | 87 Downloads )

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
JonB
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 3,785
Location: Land of the Blazing Sun!

YaBB 2.6.0
Re: GreyBox images bugs
Reply #11 - Feb 3rd, 2012 at 4:57pm
Post Tools
Dandello -

What you are saying (if I understand correctly) is that the only 'fix' needed for YaBBC.pl ver 1.4 as distributed in the YaBB2.5AE SourceForge downloads is the code substitution in your last post???

Do I have that right???
Cool
  

I find your lack of faith disturbing.
Back to top
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 2,128
Location: Earth

YaBB 2.6.0
Re: GreyBox images bugs
Reply #10 - Jan 28th, 2012 at 12:38am
Post Tools
The actual fix if you want to maintain your 2.5 files is to find
Code
Select All
sub DoUBBC {
    my $msg = _do_ubbc($message);
	$message = $msg;
}

sub _do_ubbc {
 


in YaBBC.pl and replace it with
Code
Select All
sub DoUBBC { 



This fix was documented a while back but seems to have disappeared.
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: GreyBox images bugs
Reply #9 - Jan 8th, 2011 at 2:03pm
Post Tools
New
cgi-bin/yabb3/Sources/YaBBC.pl
in SVN.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Captain John
Ex Member


Re: GreyBox images bugs
Reply #8 - Nov 29th, 2010 at 4:41am
Post Tools
Quote:
OBSERVE! - I had to add a space between '#' and 'nosmileys' (twice) to make code tags work in this post - the space should of course not be there in the code


  The space is in the CVS code YaBB_2_6_x branch; YaBBC.pl
  
Back to top
 
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: GreyBox images bugs
Reply #7 - Aug 22nd, 2010 at 11:35am
Post Tools
New
Sources/YaBBC.pl
in CVS again.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Carsten
Ex Member


Re: GreyBox images bugs
Reply #6 - Aug 22nd, 2010 at 10:59am
Post Tools
Had a even closer look at the 'noparse' code now. No offence, but that piece of code is one of the strangest and most complicated ways i've seen so far to solve a very simple regex case. Causing unnecessary sub routine recursion. And the 'noparse' tags are not working inside 'quote' and 'edit' tags ('external' quote and edit tags appear as code).

This should do the same without all the splitting and recursion and make the 'noparse' tags work inside 'quote' and 'edit' tags too (and of course still fixing the resize bug):

In YaBBC.pl find
Code
Select All
		$noubbc =~ s~([\/\]\[\.])~$killhash{$1}~g;
 


and replace it with
Code
Select All
		$noubbc =~ s~([;!\(\)\-\.\/:\?\[\\\]\^D])~$killhash{$1}~g;
 



then find
Code
Select All
sub DoUBBC {
  my $msg = _do_ubbc($message);
	$message = $msg;
}

sub _do_ubbc {
  my $message = join "", @_;
	return $message if $ns eq "NS" || $message =~ s/# nosmileys//isg;

	my $image_type = $_[0];

	if($message =~ m{(.*?)\[noparse\](.*)}) {
		my ($beginning, $temp, $middle, $end) = (undef, undef, undef, undef);
		($beginning, $temp) = ($1, $2);
		if($temp =~ m{(.*?)\[/noparse\](.*)}) {
			my ($middle, $end) = ($1, $2);
			return _do_ubbc($beginning).noparse($middle)._do_ubbc($end);
		}
		else {
			return _do_ubbc($beginning).noparse($temp);
		}
	}
 


and replace it with
Code
Select All
sub DoUBBC {
	return $message if $ns eq "NS" || $message =~ s/# nosmileys//isg;

	my $image_type = $_[0];

	$message =~ s~\[noparse\](.*?)(\[/noparse\]|$)~noparse($1)~eisg; 



OBSERVE! - I had to add a space between '#' and 'nosmileys' (twice) to make code tags work in this post - the space should of course not be there in the code

Edited:
Just to clearify: I do understand that the current code will return the 'noparse' text without running it through 'DoUBBC conversion' - what i do not understand is why, when you can simply 'kill' the smilies and avoid recursion.
« Last Edit: Aug 22nd, 2010 at 12:13pm by »  
Back to top
 
IP Logged
 
Jet Li
Legacy Dev Team
Development Team
****
Offline



Posts: 6,588
Location: Hong Kong
Re: GreyBox images bugs
Reply #5 - Aug 22nd, 2010 at 9:11am
Post Tools
New
Sources/YaBBC.pl
in CVS.
  

PM me for YaBB Installation Service
Back to top
WWWGTalkFacebook  
IP Logged
 
Fduch
Junior Member
**
Offline



Posts: 57
Location: .
Re: GreyBox images bugs
Reply #4 - Aug 18th, 2010 at 4:02am
Post Tools
@ Carsten

Thanks!
  
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: [1] 2 
Topic Tools
 
  « Board Index ‹ Board  ^Top