Page Index Toggle Pages: 1 [2] 3 4 ... 6
Topic Tools
Very Hot Topic (More than 25 Replies) PMs from Ex-Members (Read 14,808 times)
Derek Barnstorm
Support Team
YaBB Next Team
Development Team
Beta Testers
****
Offline



Posts: 1,269
Location: United Kingdom

None
Re: PMs from Ex-Members
Reply #68 - Nov 22nd, 2011 at 4:05am
Post Tools
Here you go - use the one attached here. You still had the code from an older version in there and it looks like you moved the code before:

Code (Perl)
Select All
        &ToHTML($member{'reason'}); 


Instead of:

Code (Perl)
Select All
    &ToHTML($member{'language'}); 


I'm hoping that will fix things, but let me know if you have any more problems.

------ wrote on Nov 22nd, 2011 at 3:53am:
looks like you had posted while I was grabbing the code the first time around

Ah, sorry. Too quick off the mark. Smiley
« Last Edit: Nov 22nd, 2011 at 4:10am by Derek Barnstorm »  

Register-Ron.zip ( 11 KB | 42 Downloads )
Back to top
 
IP Logged
 
------
Senior Member
Beta Testers
****
Offline



Posts: 527
Re: PMs from Ex-Members
Reply #67 - Nov 22nd, 2011 at 3:53am
Post Tools
Here you go Derek, looks like you had posted while I was grabbing the code the first time around
  

Register.zip ( 11 KB | 42 Downloads )
Back to top
 
IP Logged
 
Derek Barnstorm
Support Team
YaBB Next Team
Development Team
Beta Testers
****
Offline



Posts: 1,269
Location: United Kingdom

None
Re: PMs from Ex-Members
Reply #66 - Nov 22nd, 2011 at 3:41am
Post Tools
The last part of that code is from an earlier version of the Mod. It would help if I could see the whole of Register.pl.

And it doesn't look like you've moved it to the correct place...
« Last Edit: Nov 22nd, 2011 at 3:46am by Derek Barnstorm »  
Back to top
 
IP Logged
 
------
Senior Member
Beta Testers
****
Offline



Posts: 527
Re: PMs from Ex-Members
Reply #65 - Nov 22nd, 2011 at 3:38am
Post Tools
Maybe I do have two instances.

Code
Select All
		&FromChars($member{'reason'});

    if ($check_sfs_username || $check_sfs_ip || $check_sfs_email) {
        require "$sourcedir/StopForumSpam.pl";
        $sfs_username = $member{'regusername'};
        $sfs_email = $member{'email'};
        &CheckForumSpam;
    }

		&ToHTML($member{'reason'});
		&ToChars($member{'reason'});
		$member{'reason'} =~ s~[\n\r]{1,2}~<br />~ig;
	}

	if ($regcheck) { require "$sourcedir/Decoder.pl"; &validation_check($member{'verification'}); }



    # StopForumSpam Mod Start
    if ($check_sfs_username || $check_sfs_ip || $check_sfs_email) {

        eval { require LWP::UserAgent }; 

  
Back to top
 
IP Logged
 
Derek Barnstorm
Support Team
YaBB Next Team
Development Team
Beta Testers
****
Offline



Posts: 1,269
Location: United Kingdom

None
Re: PMs from Ex-Members
Reply #64 - Nov 22nd, 2011 at 3:35am
Post Tools
Do you mind attaching you Register.pl so I can have a look please?

I might just have to remove that feature if it's going to cause problems. I don't think it's a 'be all and end all' feature anyway.
« Last Edit: Nov 22nd, 2011 at 3:36am by Derek Barnstorm »  
Back to top
 
IP Logged
 
------
Senior Member
Beta Testers
****
Offline



Posts: 527
Re: PMs from Ex-Members
Reply #63 - Nov 22nd, 2011 at 3:30am
Post Tools
I already overwrote the Settings.pl that had the problem. The backup I used was 2 days old, sorry.

Derek Barnstorm wrote on Nov 22nd, 2011 at 1:57am:
Okay, the good news is that I have just recreated this, so I can see it happening myself.

But... I'm still 'fairly' sure that my solution in my last post fixes it. Are you absolutely sure that you totally removed this code (I'm guessing that you have two instances of it now):

Code (Perl)
Select All
    if ($check_sfs_username || $check_sfs_ip || $check_sfs_email) {
        require "$sourcedir/StopForumSpam.pl";
        $sfs_username = $member{'regusername'};
        $sfs_email = $member{'email'};
        &CheckForumSpam;
    } 


And added it directly before this line:

Code (Perl)
Select All
    &ToHTML($member{'language'}); 


That solves it for me...


Yes, that is the way I set it up but I only have one instance.

BTW, This pop-up reply box is a pain.
  
Back to top
 
IP Logged
 
Derek Barnstorm
Support Team
YaBB Next Team
Development Team
Beta Testers
****
Offline



Posts: 1,269
Location: United Kingdom

None
Re: PMs from Ex-Members
Reply #62 - Nov 22nd, 2011 at 3:01am
Post Tools
It was meant for Ron really, but I guess you too if you did want to double check. I'd appreciate it if you guys could let me know if it fixes it anyhow.

Just to explain a little more what was going on - Some malicious users are obviously attempting to upload something through the email field:

Code
Select All
file_links[d:xr-dataseogyy@gmail.com.txt1l] 


And it was being added to the ban list before it was being checked for being a valid email, so one of the characters was buggering up the settings. Adding it to the ban list after it has been checked to be valid is hopefully going to fix it.

The 'Auto-ban both IP Address and Email Address if either one matches?' option will ban the email address even if it isn't in the SFS database but the IP is, and visa versa - if that makes sense.

If it's only banned if it is in the database, then it would be already tested by SFS to be valid. It seemed to slip my mind that anything entered into the email field was going to be auto-added to the ban list with no checks. Embarrassed

I personally don't have that option enabled on my test/demo board - I only add them to the ban list if they do match emails in the database. But it's obviously up to you how strict you want to be.

Oh, I'm a night owl by the way. Smiley

« Last Edit: Nov 22nd, 2011 at 3:31am by Derek Barnstorm »  
Back to top
 
IP Logged
 
corvettec3
YaBB Newcomer
*
Offline



Posts: 38
Re: PMs from Ex-Members
Reply #61 - Nov 22nd, 2011 at 2:21am
Post Tools
Derek, is the post above meant for Jon or myself?  And according to my watch, you should be in bed now  Smiley
« Last Edit: Nov 22nd, 2011 at 2:22am by corvettec3 »  
Back to top
 
IP Logged
 
Derek Barnstorm
Support Team
YaBB Next Team
Development Team
Beta Testers
****
Offline



Posts: 1,269
Location: United Kingdom

None
Re: PMs from Ex-Members
Reply #60 - Nov 22nd, 2011 at 1:57am
Post Tools
Okay, the good news is that I have just recreated this, so I can see it happening myself.

But... I'm still 'fairly' sure that my solution in my last post fixes it. Are you absolutely sure that you totally removed this code (I'm guessing that you have two instances of it now):

Code (Perl)
Select All
    if ($check_sfs_username || $check_sfs_ip || $check_sfs_email) {
        require "$sourcedir/StopForumSpam.pl";
        $sfs_username = $member{'regusername'};
        $sfs_email = $member{'email'};
        &CheckForumSpam;
    } 


And added it directly before this line:

Code (Perl)
Select All
    &ToHTML($member{'language'}); 


That solves it for me...
« Last Edit: Nov 22nd, 2011 at 1:58am by Derek Barnstorm »  
Back to top
 
IP Logged
 
Derek Barnstorm
Support Team
YaBB Next Team
Development Team
Beta Testers
****
Offline



Posts: 1,269
Location: United Kingdom

None
Re: PMs from Ex-Members
Reply #59 - Nov 22nd, 2011 at 1:01am
Post Tools
Grrrrr!

The 2.4 code in that specific place is the same, so wouldn't make a difference.

Can you open up Settings.pl and post up your email ban list for me to see please?

They'll be under this variable:

Code (Perl)
Select All
$email_banlist = "your_email_ban_list"; # EMAIL banlist 


corvettec3 wrote on Nov 22nd, 2011 at 12:18am:
Nova Scotia (New Scotland) is on the east coast of Canada.  Just across the pond from you Derek.

Aha, I've got ya. I'll just find find my swimming trunks out, and I'll be with you shortly. Smiley
« Last Edit: Nov 22nd, 2011 at 1:07am by Derek Barnstorm »  
Back to top
 
IP Logged
 
------
Senior Member
Beta Testers
****
Offline



Posts: 527
Re: PMs from Ex-Members
Reply #58 - Nov 22nd, 2011 at 12:48am
Post Tools
Derek I really hate to say this.

I made the changes you suggested in reply#47 and then I had the problem corvettec3 mentioned, except I was getting a 500 error.

Maybe this has to do with the fact that I'm using 2.4?


(I have a case of Paulaner ready for you guys)
« Last Edit: Nov 22nd, 2011 at 12:50am by ------ »  
Back to top
 
IP Logged
 
corvettec3
YaBB Newcomer
*
Offline



Posts: 38
Re: PMs from Ex-Members
Reply #57 - Nov 22nd, 2011 at 12:18am
Post Tools
DereDerek Barnstorm wrote on Nov 21st, 2011 at 11:02pm:
corvettec3 wrote on Nov 21st, 2011 at 10:45pm:
And a well deserved beer break Smiley  Next time you are in Nova Scotia, I will have a cold one ready  Smiley

Thanks! But where the 'eck is 'Nova Scotia' - isn't that somewhere on the Moon? Cheesy

Oh, you might want to delete your Settings.pl attachment now - your email address in stored in there, so you probably don't want it lying around.




Thanks Derek, I will do that.  Nova Scotia (New Scotland) is on the east coast of Canada.  Just across the pond from you Derek.
  
Back to top
 
IP Logged
 
Derek Barnstorm
Support Team
YaBB Next Team
Development Team
Beta Testers
****
Offline



Posts: 1,269
Location: United Kingdom

None
Re: PMs from Ex-Members
Reply #56 - Nov 21st, 2011 at 11:02pm
Post Tools
corvettec3 wrote on Nov 21st, 2011 at 10:45pm:
And a well deserved beer break Smiley  Next time you are in Nova Scotia, I will have a cold one ready  Smiley

Thanks! But where the 'eck is 'Nova Scotia' - isn't that somewhere on the Moon? Cheesy

Oh, you might want to delete your Settings.pl attachment now - your email address in stored in there, so you probably don't want it lying around.


« Last Edit: Nov 21st, 2011 at 11:05pm by Derek Barnstorm »  
Back to top
 
IP Logged
 
JonB
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 3,821
Location: Land of the Blazing Sun!

YaBB 2.6.1
Re: PMs from Ex-Members
Reply #55 - Nov 21st, 2011 at 10:55pm
Post Tools
"I'd sooner have a Schooner" (Please) -- yes, I am older than dirt....

Grin

(many fond memories)
  

I find your lack of faith disturbing.
Back to top
IP Logged
 
corvettec3
YaBB Newcomer
*
Offline



Posts: 38
Re: PMs from Ex-Members
Reply #54 - Nov 21st, 2011 at 10:45pm
Post Tools
And a well deserved beer break Smiley  Next time you are in Nova Scotia, I will have a cold one ready  Smiley
  
Back to top
 
IP Logged
 
Page Index Toggle Pages: 1 [2] 3 4 ... 6
Topic Tools
 
  « Board Index ‹ Board  ^Top