Page Index Toggle Pages: 1
Topic Tools
Hot Topic (More than 10 Replies) Edit a tab created on the Add button function (Read 2,106 times)
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,129
Location: Earth

YaBB 2.6.0
Re: Edit a tab created on the Add button function
Reply #13 - Dec 11th, 2012 at 6:31pm
Post Tools
Since I've been going over the code I took a closer look at the add-tab function and decided the issue of not being able to add addresses with https and ftp addresses actually does qualify as a bug. (This is actually based on looking at what happens if you put in an address with the "http://" section already typed in. Add-tab messes it up royally.)

We should never have to put admins in the position of hand editing Settings.pl in order to get something to work properly.  Wink

The fix (for 2.5 and 2.5.2 at least )  in AdvancedTabs.pl find:
Code
Select All
		if ($taburl !~ /^\http:\/\//) { $taburl = qq~http://$taburl~; }
 


replace with:
Code
Select All
		if ($taburl !~ /^http:\/\// && $taburl !~ /^https:\/\// && $taburl !~ /^ftp:\/\// ) { $taburl = qq~http://$taburl~; }
		else {$taburl = $taburl;}
 


Grin






  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
Bill Myers
God Member
Beta Testers
*****
Offline



Posts: 1,557
Location: Los Angeles

YaBB 2.4
Re: Edit a tab created on the Add button function
Reply #12 - Jul 27th, 2012 at 6:45pm
Post Tools
xnoddyx wrote on Jul 27th, 2012 at 6:38pm:
if when you make a new menu tab and it is not http:// but https:// you can edit cgi-bin/yabb2/Variables/Settings.pl open and look for and edit
Code
Select All
########## Advanced Tabs ##########

@AdvancedTabs = ("test|http://test.co.uk|0|0|0|0|","website_home|http://home.co.uk/|0|0|0|0|","games|http://games.co.uk/|0|0|0|0|","home","help","search","ml","admin","revalidatesession","login","register","guestpm","mycenter","logout","chatce","awards","rating"); # Advanced Tabs order and infos 


Wink

I was thinking that as well, but then as Dave ended up doing, and what I do myself, it's a lot easier to simply delete the badly linked menu tab, and create it again with the correct link.

Once you learn how this add/edit function actually works, it's really quite easy.  Smiley

Edited:
To clarify, I mean plural "you" about how easy this is.  Wink

« Last Edit: Jul 27th, 2012 at 6:54pm by Bill Myers »  

Morning, noon, or night, have a great one!

Note: This forum doesn't allow for us to freely edit our posts or topics to make corrections as needed, so please remember to look for subsequent posts if you see any mistakes or outdated information. Sorry for the inconvenience.
Back to top
IP Logged
 
xnoddyx
Support Team
Documentation Team
YaBB Moderators
YaBB Next Team
Beta Testers
****
Offline



Posts: 1,584
Location: UK:Scotland/livingston

None
Re: Edit a tab created on the Add button function
Reply #11 - Jul 27th, 2012 at 6:38pm
Post Tools
DaveRolph wrote on Jul 26th, 2012 at 11:17am:
Thanks but its not the text label I wanted to edit but the content of the link itself, however your response did help as I could delete it and re-create it.

There seems to be a bug with the way the link works if you enter a https:// address, I have created a workaround with a re-direct on my site but I thought I would mention it here for possible future users.

if when you make a new menu tab and it is not http:// but https:// you can edit cgi-bin/yabb2/Variables/Settings.pl open and look for and edit
Code
Select All
########## Advanced Tabs ##########

@AdvancedTabs = ("test|http://test.co.uk|0|0|0|0|","website_home|http://home.co.uk/|0|0|0|0|","games|http://games.co.uk/|0|0|0|0|","home","help","search","ml","admin","revalidatesession","login","register","guestpm","mycenter","logout","chatce","awards","rating"); # Advanced Tabs order and infos 


Wink
« Last Edit: Jul 27th, 2012 at 6:40pm by xnoddyx »  

YaBB install help video
1. what yabb forum are you running and the url
2. describe in as much detail as you can what happens and also post screenshots if you can
3. please be patient we live in different time zones and have other commitments but we will help you
as bill and ted say (Be excellent to each other)
Back to top
IP Logged
 
Bill Myers
God Member
Beta Testers
*****
Offline



Posts: 1,557
Location: Los Angeles

YaBB 2.4
Great Feature! Re: Add/edit menu tab options
Reply #10 - Jul 27th, 2012 at 5:49pm
Post Tools
Dandello wrote on Jul 27th, 2012 at 3:10pm:
Not being able to edit tabs the way you think you should is NOT A BUG. It may be an annoyance, but that feature is working exactly as it was designed to. It may not be pretty, it may be convoluted, but it works.

I agree. That was my thinking all along, which is why I never reported it as a bug. I was just following up on Derek's post since he had me thinking I should have reported it.

Being a moderator, I guess it's good he didn't move my post over to the wrong place. Wink

****************************************

Quote:
As Dandello already explained, not being able to edit the URL (or 'New window' or 'Visible to' for that matter) is not a bug - it's a "kiss feature" Smiley and was designed to work exactly as it does. I personally dont find it ugly or convoluted - I find it beautiful and functional - but then again I may be slightly biased Smiley

Again, this is what I thought as well. I quite like that YaBB has for me a very easy to use editing feature for adding and modifying menu tabs. Also for me personally, I'm used to the way it was designed to work, and I find it works perfectly well.
The fact that we admins of YaBB can add/edit menu tabs; Sweet!  Smiley

  

Morning, noon, or night, have a great one!

Note: This forum doesn't allow for us to freely edit our posts or topics to make corrections as needed, so please remember to look for subsequent posts if you see any mistakes or outdated information. Sorry for the inconvenience.
Back to top
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,129
Location: Earth

YaBB 2.6.0
Re: Edit a tab created on the Add button function
Reply #9 - Jul 27th, 2012 at 5:15pm
Post Tools
My convoluted comment was aimed at those who seem to think there should only be single step one-size-fits-all solutions.
I think it works just fine. I mean, you have to take multiple steps for complex formatting, too. (There's no combined Bold and Italics buttons out there on any word processor I know of either. So multiple steps on editing tabs isn't a biggie.)
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
Carsten
Ex Member


Re: Edit a tab created on the Add button function
Reply #8 - Jul 27th, 2012 at 3:57pm
Post Tools
As Dandello already explained, not being able to edit the URL (or 'New window' or 'Visible to' for that matter) is not a bug - it's a "kiss feature" Smiley and was designed to work exactly as it does. I personally dont find it ugly or convoluted - I find it beautiful and functional - but then again I may be slightly biased Smiley

As to not being able to place a new tab where you want it (initially) as described by Bill - in all my 6 test boards have no problem with that feature - works nicely.
  
Back to top
 
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,129
Location: Earth

YaBB 2.6.0
Re: Edit a tab created on the Add button function
Reply #7 - Jul 27th, 2012 at 3:10pm
Post Tools
A bug is defined as a coding issue that interferes with the functioning of the forum. (Like only being able to use your password to revalidate your session when you should be able to use your zipcode is a bug. It's not working the way it's supposed to. Which is why we have a bug-fix for it.)

Not being able to edit tabs the way you think you should is NOT A BUG. It may be an annoyance, but that feature is working exactly as it was designed to. It may not be pretty, it may be convoluted, but it works.
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
Bill Myers
God Member
Beta Testers
*****
Offline



Posts: 1,557
Location: Los Angeles

YaBB 2.4
Re: Edit a tab created on the Add button function
Reply #6 - Jul 27th, 2012 at 8:19am
Post Tools
Quote:
Bill

It has been said before however, if you believe you have found a bug can you please record it in the YaBB Next Bugs [Need Verification] Board so that our developers can look at it and if necessary act on it.

Thanks


Derek

Hi Derek,

Do you mean the section here in this forum?

Or do you mean the section here in this forum?

I'm guessing I should mention the editing bug in the 2nd link above since I'm using version 2.4 right?

Just in case you weren't aware of it, bug reports for YaBB 2 still seem to be unresolved starting back on July 19, 2009. Do you know when they might get these already reported bugs fixed, or should we simply go with what I explained here to deal with the editing bug?

Three years for a bug fix is a tad long, isn't it? Smiley Some clarification about this would be appreciated.  Smiley

By the way, maybe someone can take a look at the bugs that have been reported since 2009 since I'm guessing they may have been fixed with the release of YaBB 2.5AE a while back.

Edited:
Edited to clean up some formatting. And ...

The "bug" if there is one is described as follows (using YaBB 2.4):

After choosing the edit icon to the right of the menu tabs, all one can do with any given menu tab is to modify the name of the tab. Unfortunately, one cannot edit the associated link.

Is that considered a bug?  Huh

Strangely enough, in what I can see from the instructions that come onto the screen while editing, YaBB's editing tool may not have been designed to edit any given menu tab's associated link.

In lieu of fixing this bug, if that's what it is, the solution is to simply delete the menu tab in question, and recreate it again with the correct link association.

I guess I should add that there is at least one other bug with this editing tool, which is not being able to place a new menu tab where you want it; at least not initially.

However, this additional "bug" if that's what it is can be mitigated with clever manipulation to make it work.

Specifically, to move a menu tab where you want it after creating it, and then saving your work, click the editing icon again, and then you'll be able to move your newly created menu tab where you want it to be (along with any others). The 2nd time is the charm.

By the way, if after you add a menu tab, and you try to place it anywhere other than at the front, it won't appear in the menu at all. So just put it in front (your only option), and then edit it a 2nd time to move it where you want.

There may be some other quirky things going on with YaBB's editing tool to add or edit menu tabs, but again, you can make it work with some clever manipulation.

The point is, it does work!  Wink


Edited:
Quote:
As to not being able to place a new tab where you want it (initially) as described by Bill - in all my 6 test boards have no problem with that feature - works nicely.

Good to know. Then I guess it just affects our forum in the 2.4 version I use. But then, this isn't a problem for me at all since I've learned how to make it work anyway.
I love that we admins have this feature in YaBB.  Smiley

« Last Edit: Jul 27th, 2012 at 5:53pm by Bill Myers »  

Morning, noon, or night, have a great one!

Note: This forum doesn't allow for us to freely edit our posts or topics to make corrections as needed, so please remember to look for subsequent posts if you see any mistakes or outdated information. Sorry for the inconvenience.
Back to top
IP Logged
 
Derek Bullock
Ex Member


Re: Edit a tab created on the Add button function
Reply #5 - Jul 27th, 2012 at 7:09am
Post Tools
Bill Myers wrote on Jul 26th, 2012 at 8:59pm:
[quote author=1A3F283B0C31322E365E0 link=1343300190/2#2 date=1343301434]
This "bug" is an irritation, no doubt, but as you now know, the work-around of deleting the menu tab, and recreating it is easy enough to do.


Bill

It has been said before however, if you believe you have found a bug can you please record it in the YaBB Next Bugs [Need Verification] Board so that our developers can look at it and if necessary act on it.

Thanks


Derek
  
Back to top
 
IP Logged
 
Bill Myers
God Member
Beta Testers
*****
Offline



Posts: 1,557
Location: Los Angeles

YaBB 2.4
Re: Edit a tab created on the Add button function
Reply #4 - Jul 26th, 2012 at 8:59pm
Post Tools
DaveRolph wrote on Jul 26th, 2012 at 11:17am:
I could delete it and re-create it.

There seems to be a bug with the way the link works ...

I noticed this as well a long time ago since I've been fond of adding tabs to our forum's menu, including those that are only available to admins.

This "bug" is an irritation, no doubt, but as you now know, the work-around of deleting the menu tab, and recreating it is easy enough to do.

Sometimes it's taken me a few tries to get it right.  Roll Eyes

  

Morning, noon, or night, have a great one!

Note: This forum doesn't allow for us to freely edit our posts or topics to make corrections as needed, so please remember to look for subsequent posts if you see any mistakes or outdated information. Sorry for the inconvenience.
Back to top
IP Logged
 
Derek Bullock
Ex Member


Re: Edit a tab created on the Add button function
Reply #3 - Jul 26th, 2012 at 11:38am
Post Tools
You got it. It does not allow you to edit the link unfortunately

Cheers


Derek
  
Back to top
 
IP Logged
 
DaveRolph
Junior Member
**
Offline



Posts: 82
Location: Barnsley (South Yorkshire)
Re: Edit a tab created on the Add button function
Reply #2 - Jul 26th, 2012 at 11:17am
Post Tools
Thanks but its not the text label I wanted to edit but the content of the link itself, however your response did help as I could delete it and re-create it.

There seems to be a bug with the way the link works if you enter a https:// address, I have created a workaround with a re-direct on my site but I thought I would mention it here for possible future users.
  
Back to top
WWW  
IP Logged
 
Derek Bullock
Ex Member


Re: Edit a tab created on the Add button function
Reply #1 - Jul 26th, 2012 at 10:59am
Post Tools
If you have a standard installation, look to the right of your TABS and you will see this little image

Click on  it to edit your tabs.

Cheers


Derek
  
Back to top
 
IP Logged
 
DaveRolph
Junior Member
**
Offline



Posts: 82
Location: Barnsley (South Yorkshire)
Edit a tab created on the Add button function
Jul 26th, 2012 at 10:56am
Post Tools
I added a new tab in my YABB 2.5AE installation and copied a hyperlink from my browser but it missed the : mark from it, where can I edit this location from please ?
  
Back to top
WWW  
IP Logged
 
Page Index Toggle Pages: 1
Topic Tools
 
  « Board Index ‹ Board  ^Top