Page Index Toggle Pages: 1 [2] 
Topic Tools
Very Hot Topic (More than 25 Replies) Admin only registration mode still displays Register button (Read 6,606 times)
xnoddyx
Support Team
Documentation Team
YaBB Moderators
YaBB Next Team
Beta Testers
****
Offline



Posts: 1,584
Location: UK:Scotland/livingston

None
Re: Admin only registration mode still displays Register button
Reply #14 - Aug 22nd, 2012 at 7:02pm
Post Tools
Derek Barnstorm wrote on Aug 22nd, 2012 at 6:14pm:
I've been thinking about this, and seeing as the password reminder was originally left there in case an administrator forgot their password - and I can see that issue coming up at some point in the future - then maybe it would be best to leave the 'Forgot Password' button visible when the forum is in maintenance mode, but do a check when clicked to only allow admins to change their password and throw an error to anyone else. I don't know what you guys and girls think of that?

i like the sound of that but was also thinking about whatever it is happens when the password gets corrupted so the admin needs to ftp into the server to fix this.
can some kind of check be made to check for password corrupted and then set a new password for the admin and email it or a url link emailed to reset it?
  

YaBB install help video
1. what yabb forum are you running and the url
2. describe in as much detail as you can what happens and also post screenshots if you can
3. please be patient we live in different time zones and have other commitments but we will help you
as bill and ted say (Be excellent to each other)
Back to top
IP Logged
 
Derek Barnstorm
Support Team
YaBB Next Team
Development Team
Beta Testers
****
Offline



Posts: 1,269
Location: United Kingdom

None
Re: Admin only registration mode still displays Register button
Reply #13 - Aug 22nd, 2012 at 6:14pm
Post Tools
I've been thinking about this, and seeing as the password reminder was originally left there in case an administrator forgot their password - and I can see that issue coming up at some point in the future - then maybe it would be best to leave the 'Forgot Password' button visible when the forum is in maintenance mode, but do a check when clicked to only allow admins to change their password and throw an error to anyone else. I don't know what you guys and girls think of that?
« Last Edit: Aug 22nd, 2012 at 6:24pm by Derek Barnstorm »  
Back to top
 
IP Logged
 
xnoddyx
Support Team
Documentation Team
YaBB Moderators
YaBB Next Team
Beta Testers
****
Offline



Posts: 1,584
Location: UK:Scotland/livingston

None
Re: Admin only registration mode still displays Register button
Reply #12 - Aug 16th, 2012 at 10:08pm
Post Tools
Dandello wrote on Aug 16th, 2012 at 5:31pm:
Off the top of my head - I've lost count.  Tongue
At least 5. And a couple are just brain-boggling.

5 is not that bad is it or is that deep code?
ooo like that i think its always good to give the brain-boggling a time out and then come back to it as if you dont it will only drive you mad lol

Dandello wrote on Aug 16th, 2012 at 8:39pm:
Derek, has anyone told you recently that you're a genius?   Grin

and +1 me on that  Grin

  

YaBB install help video
1. what yabb forum are you running and the url
2. describe in as much detail as you can what happens and also post screenshots if you can
3. please be patient we live in different time zones and have other commitments but we will help you
as bill and ted say (Be excellent to each other)
Back to top
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,130
Location: Earth

YaBB 2.6.0
Re: Admin only registration mode still displays Register button
Reply #11 - Aug 16th, 2012 at 8:39pm
Post Tools
Derek, has anyone told you recently that you're a genius?   Grin
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
Derek Barnstorm
Support Team
YaBB Next Team
Development Team
Beta Testers
****
Offline



Posts: 1,269
Location: United Kingdom

None
Re: Admin only registration mode still displays Register button
Reply #10 - Aug 16th, 2012 at 8:23pm
Post Tools
The following highlighted lines should be removed from YaBB.pl too - otherwise users can still access the password reminder page:

Code (Perl)
Select All
    if ($maintenance) {
        if    ($action eq 'login2')    { require "$sourcedir/LogInOut.pl"; &Login2; }
        # Allow password reminders in case admins forgets their admin password
        elsif ($action eq 'reminder')  { require "$sourcedir/LogInOut.pl"; &Reminder; }
        elsif ($action eq 'validate')  { require "$sourcedir/Decoder.pl"; &convert; }
        elsif ($action eq 'reminder2') { require "$sourcedir/LogInOut.pl"; &Reminder2; }
        elsif ($action eq 'resetpass') { require "$sourcedir/LogInOut.pl"; &Reminder3; }

        if (!$iamadmin) { require "$sourcedir/LogInOut.pl"; &InMaintenance; }
    } 

  
Back to top
 
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,130
Location: Earth

YaBB 2.6.0
Re: Admin only registration mode still displays Register button
Reply #9 - Aug 16th, 2012 at 6:40pm
Post Tools
Thanks for reminding me of that. (I'd also forgotten there was a fix elsewhere.) And you're right, hard-coding the text is not a good idea.
« Last Edit: Aug 16th, 2012 at 6:42pm by Dandello »  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
Derek Barnstorm
Support Team
YaBB Next Team
Development Team
Beta Testers
****
Offline



Posts: 1,269
Location: United Kingdom

None
Re: Admin only registration mode still displays Register button
Reply #8 - Aug 16th, 2012 at 6:08pm
Post Tools
There was already a fix for this on the dev board:

http://www.dev.yabbworld.com/cgi-bin/forum/YaBB.pl?num=1294562849

Anyway, I think it makes more sense to hide the buttons rather than display text which could end up looking ugly. By the way, you shouldn't be hardcoding text - YaBB is translated into different languages. Wink

Find:

Code (Perl)
Select All
    if ($maintenance || !$regtype) { $dbutton = ' disabled="disabled"'; } 


Replace:

Code (Perl)
Select All
    if ($maintenance) { $hide_passbutton = " visibility: hidden;"; }
    if ($maintenance || !$regtype) { $hide_regbutton = " visibility: hidden;"; } 


Find:

Code (Perl)
Select All
                        <input type="button" value="$maintxt{'97'}"$dbutton style="width: 160px;" onclick="location.href='$scripturl?action=register'" tabindex="6" class="button" /> 


Replace:

Code (Perl)
Select All
                        <input type="button" value="$maintxt{'97'}" style="width: 160px;$hide_regbutton" onclick="location.href='$scripturl?action=register'" tabindex="6" class="button" /> 


Find:

Code (Perl)
Select All
                        <input type="button" value="$loginout_txt{'315'}"$dbutton style="width: 160px;" onclick="location.href='$scripturl?action=reminder'" tabindex="5" class="button" /> 


Replace:

Code (Perl)
Select All
                        <input type="button" value="$loginout_txt{'315'}" style="width: 160px;$hide_passbutton" onclick="location.href='$scripturl?action=reminder'" tabindex="5" class="button" /> 

« Last Edit: Aug 16th, 2012 at 8:23pm by Derek Barnstorm »  
Back to top
 
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,130
Location: Earth

YaBB 2.6.0
Re: Admin only registration mode still displays Register button
Reply #7 - Aug 16th, 2012 at 5:31pm
Post Tools
Off the top of my head - I've lost count.  Tongue
At least 5. And a couple are just brain-boggling.
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
xnoddyx
Support Team
Documentation Team
YaBB Moderators
YaBB Next Team
Beta Testers
****
Offline



Posts: 1,584
Location: UK:Scotland/livingston

None
Re: Admin only registration mode still displays Register button
Reply #6 - Aug 16th, 2012 at 5:26pm
Post Tools
out of curiosity how meny items are on the todo list now?
  

YaBB install help video
1. what yabb forum are you running and the url
2. describe in as much detail as you can what happens and also post screenshots if you can
3. please be patient we live in different time zones and have other commitments but we will help you
as bill and ted say (Be excellent to each other)
Back to top
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,130
Location: Earth

YaBB 2.6.0
Re: Admin only registration mode still displays Register button
Reply #5 - Aug 16th, 2012 at 5:14pm
Post Tools
We could also give the admin a choice of messages - one for 'This board is Closed' and one for 'Registration is by Admin only' and use the YaBB email function to hide the Admin's email. (I would also recommend the Admin get a disposable email account if doing this.)

On the todo list.
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
xnoddyx
Support Team
Documentation Team
YaBB Moderators
YaBB Next Team
Beta Testers
****
Offline



Posts: 1,584
Location: UK:Scotland/livingston

None
Re: Admin only registration mode still displays Register button
Reply #4 - Aug 16th, 2012 at 5:05pm
Post Tools
Dandello wrote on Aug 16th, 2012 at 4:59pm:
Register button, it will say 'Registrations are closed or by Admin only.' (Another tweak would be to put in the Admin's email - or maybe not.)

maybe make this a Broadcast message to Admin's ?

Edited:
this just reminded me of a bug to post
« Last Edit: Aug 16th, 2012 at 5:07pm by xnoddyx »  

YaBB install help video
1. what yabb forum are you running and the url
2. describe in as much detail as you can what happens and also post screenshots if you can
3. please be patient we live in different time zones and have other commitments but we will help you
as bill and ted say (Be excellent to each other)
Back to top
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,130
Location: Earth

YaBB 2.6.0
Re: Admin only registration mode still displays Register button
Reply #3 - Aug 16th, 2012 at 4:59pm
Post Tools
And now you know why I refuse to move to Florida.

and for a fix to this issue: See Derek Barnstorm's post.

« Last Edit: Aug 16th, 2012 at 6:46pm by Dandello »  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
batchman
Support Team
****
Offline



Posts: 371
Location: Orlando, FL
Re: Admin only registration mode still displays Register button
Reply #2 - Aug 16th, 2012 at 3:33pm
Post Tools
Hey! Some of us don't "choose" to go out, it is chosen for us, unless we no longer want to have a job.

Somebody remind me, why the heck did I ever move to Florida?!?

I hate summertime!
  
Back to top
 
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,130
Location: Earth

YaBB 2.6.0
Re: Admin only registration mode still displays Register button
Reply #1 - Aug 16th, 2012 at 3:02pm
Post Tools
Oh Goodie - more to do on a day when I can't get out due to the weather. (Unlike you East Coast people, North-Westerners know better than to brave 3 digit temperatures outside when they have AC.)
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
JonB
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 3,785
Location: Land of the Blazing Sun!

YaBB 2.6.0
Admin only registration mode still displays Register button
Aug 16th, 2012 at 2:44pm
Post Tools
Version 2.5 AE - Cosmetic Error

If a Forum is in admin-only registration mode, although the YaBB tab menu does not display 'Register', the login form still displays the Register button (although it is not functional). Its deceptive even to the Admin - I was testing my theory on cookies when I uncovered this, I was 'why can I not register!?'.  It says 'Register right there", LOL

I think we knew about this before, and there may have been a reason that the button was still displayed, although it is disabled.  I'm really unsure.  I know the login area was reworked -- I think at 2.3.1

I  know - blah, blah, blah -  Wink


Cool
  

I find your lack of faith disturbing.
Back to top
IP Logged
 
Page Index Toggle Pages: 1 [2] 
Topic Tools
 
  « Board Index ‹ Board  ^Top