Page Index Toggle Pages: [1] 2 3 
Topic Tools
Very Hot Topic (More than 25 Replies) Username=Email Address Breaks Password Retrival (Read 1,409 times)
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,293
Location: Earth

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #32 - Apr 25th, 2014 at 5:36pm
Post Tools
It's not using email addresses as the personal identifier in the login field that breaks things - it's when the user ID has an '@' in it. That breaks the password retrieval.
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
Bill Myers
God Member
Beta Testers
*****
Offline



Posts: 1,630
Location: Los Angeles

YaBB 2.5
Locked topic: Re: Username=Email Address Breaks Password Retrival
Reply #31 - Apr 25th, 2014 at 3:41pm
Post Tools
Note to Dandello: I'm thinking it's best for you to update your post to make it more complete since that's the place full instructions should be; not here. As such, please feel free to modify this post of mine, or better yet, delete it altogether since information coming only from you would be best. Thanks.

************************************

Because Dandello locked her topic, I've quoted her post in that topic below so that anyone using version 2.4 can find {"$key"} in both places of the LogInOut.pl file; not just the one place she mentions.

As close as this forum allows, the following is what Dandello posted (source):

Quote:
The fix for 2.4, 2.5 and 2.5.2

In LogInOut.pl find
Code
Select All
print FILE qq~\$pass{"$key"} = '$value';\n~; 


replace with:
Code
Select All
print FILE qq~\$pass{'$key'} = '$value';\n~; 



This code is in two places in LogInOut.pl and both need to be replaced.

What Dandello noted above is the 1st place in the LogInOut.pl file that you will find {"$key"}. In my 2.4 forum it's located on line 311 although yours may be found on a different line.

The 2nd place is as follows (on line 363 in my forum; yours may be different):

In LogInOut.pl find
Code
Select All
print FORGOTTEN qq~\$pass{"$key"} = '$value';\n~; 


replace with:
Code
Select All
print FORGOTTEN qq~\$pass{'$key'} = '$value';\n~; 


To qualify my addition to Dandello's instructions, it should be noted that I haven't had a problem with email addresses breaking the password retrieval function. As such, I have not made these changes, which are evidently needed to fix what I think has otherwise been classified as a bug.

  

Morning, noon, or night, have a great one!

Note: This forum doesn't allow for us to freely edit our posts or topics to make corrections as needed, so please remember to look for subsequent posts if you see any mistakes or outdated information. Sorry for the inconvenience.
Back to top
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,293
Location: Earth

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #30 - Apr 24th, 2014 at 11:15pm
Post Tools
The fix for 2.4, 2.5 and 2.5.2

In LogInOut.pl find
Code (Perl)
Select All
print FILE qq~\$pass{"$key"} = '$value';\n~; 


replace with:
Code (Perl)
Select All
print FILE qq~\$pass{'$key'} = '$value';\n~; 



This code is in two places in LogInOut.pl and both need to be replaced.
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
JonB
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 3,846
Location: Land of the Blazing Sun!

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #29 - Apr 23rd, 2014 at 8:58pm
Post Tools
Excellent!

Cool
  

I find your lack of faith disturbing.
Back to top
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,293
Location: Earth

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #28 - Apr 23rd, 2014 at 7:54pm
Post Tools
JonB wrote on Apr 23rd, 2014 at 6:58pm:
I think I was asking was 'Do I need to manually edit Settings.pm' ???

Cool


No.  Grin
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
JonB
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 3,846
Location: Land of the Blazing Sun!

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #27 - Apr 23rd, 2014 at 6:58pm
Post Tools
I think I was asking was 'Do I need to manually edit Settings.pm' ???

Cool
  

I find your lack of faith disturbing.
Back to top
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,293
Location: Earth

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #26 - Apr 23rd, 2014 at 6:29pm
Post Tools
JonB wrote on Apr 23rd, 2014 at 5:54pm:
How does that impact the Beta forums that are already running?  Huh


Not much - The big one is the fixes in LogInOut.pm. The rest are language and some fixes for the Calendar/Birthday List if you have DateTime::TimeZones available.
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
JonB
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 3,846
Location: Land of the Blazing Sun!

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #25 - Apr 23rd, 2014 at 5:59pm
Post Tools
Dandello wrote on Apr 23rd, 2014 at 3:12pm:
The Admin choices on e-mail as user ID or Screen Name will wait for 2.6.2 as it's actually a bit more convoluted than expected and email as password needs to be addressed.


Speaking of that - there's an interesting post on the Admin Test Beta

(it's still running an older build)

Ugggh - I am working from my laptop & a linux workstation for now. My # one machine 'smoked' itself literally this AM

Undecided
  

I find your lack of faith disturbing.
Back to top
IP Logged
 
JonB
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 3,846
Location: Land of the Blazing Sun!

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #24 - Apr 23rd, 2014 at 5:54pm
Post Tools
OK -

Dandello wrote on Apr 23rd, 2014 at 3:12pm:
Build 1475 has a slightly different format in Settings_Main for demarcating the Time functions and a link to a new Help section that should explain things better. (In 2.6.2 or 2.8.0 Admin Help needs to be reorganized.)


How does that impact the Beta forums that are already running?  Huh

thanks
Smiley
  

I find your lack of faith disturbing.
Back to top
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,293
Location: Earth

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #23 - Apr 23rd, 2014 at 3:12pm
Post Tools
Finally got the newest build uploaded to SourceForge (They were having serious issues yesterday.)

Build 1475 has a slightly different format in Settings_Main for demarcating the Time functions and a link to a new Help section that should explain things better. (In 2.6.2 or 2.8.0 Admin Help needs to be reorganized.)

Spaces in User ID's is no longer allowed. (I think I caught all the language changes for that but the old 'conversion' coding is still in place for older forums/user IDs.)

And the fix for 'at' in User ID with password retrieval is in LogInOut.

The Admin choices on e-mail as user ID or Screen Name will wait for 2.6.2 as it's actually a bit more convoluted than expected and email as password needs to be addressed.

I think May 1 would be a good roll-out date so there isn't time for testing a fairly major change in Registration.
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
JonB
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 3,846
Location: Land of the Blazing Sun!

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #22 - Apr 23rd, 2014 at 10:53am
Post Tools
OK, Thanks very much

Smiley
  

I find your lack of faith disturbing.
Back to top
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,293
Location: Earth

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #21 - Apr 23rd, 2014 at 1:06am
Post Tools
I can't upload any changes to the SVN at the moment - SourceForge appeares to be down or at least running so slowly as render it useless.

In the works: no more spaces in user IDs, the proper fix for forgotten.passes, admin choice to allow user IDs or Screen names to be the same as the user's e-mail address.

Apparently both full stop (AKA dots or periods) and 'at' are legal for file names so there's no real reason to limit them as long as forgotten.passes renders them properly for password reset.
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,293
Location: Earth

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #20 - Apr 21st, 2014 at 3:55pm
Post Tools
A more 'universal' fix for forgotten.passes

In Sources/ LogInOut find
Code (Perl)
Select All
        print {FORGOTTEN} qq~\$pass{"$key"} = '$value';\n~ 

(there are 2 and they might not look exactly like this.) Replace with
Code
Select All
        print {FORGOTTEN} qq~\$pass{'$key'} = '$value';\n~ 


  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
Dandello
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Online



Posts: 2,293
Location: Earth

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #19 - Apr 21st, 2014 at 2:55pm
Post Tools
The problem with the @ in user IDs is a 'reserved character' issue in Perl - @ is the designation for an array and when that is seen in a double quoted hash key (which is how forgotten.passes is coded) that character makes Perl look for an array of the name '@gmail' or whatever to tack on (which doesn't exist so it tacks on nothing) - unlessthe @ has a '\' in front of it.

Had forgotten.passes not been coded as a hash, the problem might not have existed. So I'd call this a lack of thorough testing and imagination.

For 2.6.0 I'll disallow '@' and '.' in user IDs which will automatically block email addresses from being used as user IDs. The fix in LogInOut will have to stay for old forums - who's to say how many users have '@' in their user IDs?

We can also disallow email addys from being Screen names. (Probably  as an admin option.)
(And I just relialized there may be an easier fix for the '@' problem. But I have to test it.)
  

If you only have one solution to a problem you're not trying hard enough!
Back to top
WWW  
IP Logged
 
JonB
YaBB Administrator
YaBB Next Team
Operations Team
Beta Testers
Support Team
*****
Offline



Posts: 3,846
Location: Land of the Blazing Sun!

YaBB 2.6.1
Re: Username=Email Address Breaks Password Retrival
Reply #18 - Apr 21st, 2014 at 1:51pm
Post Tools
OK! Coool.

GOOD detective work!  Smiley

I'm glad you got to the bottom of it... I'll test later on 2.4 (although I will admit the explanation has me confused still)

Thanks!

I think you are right that '@' symbols should not be allowed in Usernames and that would also eliminate username=email_address (pile of stones) making the keys unique. Does the e-mail address form field currently mandate the '@' symbol?

The only question really is - Is the "no '@' in username" decision a 'YaBB team mandate based on good methods'. (my thinking is 'yes' currently)

thanks very much for taking the time on a holiday weekend.

Smiley
« Last Edit: Apr 21st, 2014 at 1:55pm by JonB »  

I find your lack of faith disturbing.
Back to top
IP Logged
 
Page Index Toggle Pages: [1] 2 3 
Topic Tools
 
  « Board Index ‹ Board  ^Top